Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasme deploy fails when configuration contains zipkin config #261

Closed
asayah opened this issue Apr 28, 2021 · 2 comments
Closed

wasme deploy fails when configuration contains zipkin config #261

asayah opened this issue Apr 28, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@asayah
Copy link

asayah commented Apr 28, 2021

add:

spec:
  bindAddress: '::'
  bindPort: 8080
  httpGateway:
    options:
      httpConnectionManagerSettings:
        tracing:
          verbose: true
          requestHeadersForTags:
            - path
            - origin
          zipkinConfig:
            collectorEndpoint: /api/v2/spans
            collectorEndpointVersion: HTTP_JSON
            collectorUpstreamRef:
              name: zipkin
              namespace: default
  proxyNames:
  - gateway-proxy
  ssl: false

then

--- ~ » wasme deploy gloo webassemblyhub.io/asayah/add-header:v0.2 --id=add-header                                                                                                                                                    130 ↵
Error: All attempts fail:
#1: converting output crd: reading crd spec on resource gateway-proxy in namespace gloo-system into v1Gateway: unknown field "zipkinConfig" in tracing.ListenerTracingSettings
@asayah asayah added the bug Something isn't working label Apr 28, 2021
@Sodman
Copy link
Member

Sodman commented May 13, 2021

What versions of Gloo & wasme were you using when you hit this? Looks like we just need to bump the gloo dependency to something newer, as wasme is missing the new fields.

@Sodman
Copy link
Member

Sodman commented Jun 7, 2021

Will also be fixed when #257 is done, same root cause, closing as duplicate.

@Sodman Sodman closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants