-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI Standard Image should support more than one layer #292
Labels
enhancement
New feature or request
Comments
this seems like a reasonable feature request / proposal to me. i'm not sure when the current team will have the bandwidth to take this on, but I'd be happy to work with you on this @jcchavezs if you want to make an open source contribution. fyi @yuval-k |
Indeed I want to contribute to this! Next week will be.
…On Mon, 1 Aug 2022, 16:13 Kevin Dorosh, ***@***.***> wrote:
this seems like a reasonable feature request / proposal to me. i'm not
sure when the current team will have the bandwidth to take this on, but I'd
be happy to work with you on this @jcchavezs
<https://github.com/jcchavezs> if you want to make an open source
contribution.
fyi @yuval-k <https://github.com/yuval-k>
—
Reply to this email directly, view it on GitHub
<#292 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAUWRR4ARGRLP7TCWYLVW7LRBANCNFSM537BUY7Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jcchavezs
added a commit
to jcchavezs/wasm
that referenced
this issue
Aug 22, 2022
This allows us to annotate images like docker ones with labels and still keep the files in a single layer. Fixes solo-io#292
This was referenced Aug 22, 2022
kdorosh
pushed a commit
that referenced
this issue
Aug 23, 2022
* feat: changes the spec to support more than one layer This allows us to annotate images like docker ones with labels and still keep the files in a single layer. Fixes #292 * chore: fixes wording. Co-authored-by: Takeshi Yoneda <[email protected]> * chore: improves wording. Co-authored-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
According to the spec OCI images should only contain one layer, however some use cases where you want to annotate the images with metadata aren't supported under this spec. For example this issue and the case where a docker image can't be annotated with labels because that generates more than one layer e.g.
Describe the solution you'd like
I think a good solution would be to make the convention that the last layer is going to be extracted instead of requiring to have only one layer (or two for artifacts)
Describe alternatives you've considered
Not annotating the images which is possible but labels help to search for sources of images.
cc @nacx @mathetake @anuraaga
The text was updated successfully, but these errors were encountered: