Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI Standard Image should support more than one layer #292

Closed
jcchavezs opened this issue Jul 19, 2022 · 2 comments · Fixed by #293
Closed

OCI Standard Image should support more than one layer #292

jcchavezs opened this issue Jul 19, 2022 · 2 comments · Fixed by #293
Labels
enhancement New feature or request

Comments

@jcchavezs
Copy link
Contributor

Is your feature request related to a problem? Please describe.
According to the spec OCI images should only contain one layer, however some use cases where you want to annotate the images with metadata aren't supported under this spec. For example this issue and the case where a docker image can't be annotated with labels because that generates more than one layer e.g.

FROM scratch

ARG OCI_SOURCE
ARG OCI_REVISION
LABEL org.opencontainers.image.title my-image
LABEL org.opencontainers.image.source $OCI_SOURCE
LABEL org.opencontainers.image.revision $OCI_REVISION

COPY ./build/my-wasm.wasm /plugin.wasm

Describe the solution you'd like
I think a good solution would be to make the convention that the last layer is going to be extracted instead of requiring to have only one layer (or two for artifacts)

Describe alternatives you've considered
Not annotating the images which is possible but labels help to search for sources of images.

cc @nacx @mathetake @anuraaga

@jcchavezs jcchavezs added the enhancement New feature or request label Jul 19, 2022
@kdorosh
Copy link

kdorosh commented Aug 1, 2022

this seems like a reasonable feature request / proposal to me. i'm not sure when the current team will have the bandwidth to take this on, but I'd be happy to work with you on this @jcchavezs if you want to make an open source contribution.

fyi @yuval-k

@jcchavezs
Copy link
Contributor Author

jcchavezs commented Aug 1, 2022 via email

jcchavezs added a commit to jcchavezs/wasm that referenced this issue Aug 22, 2022
This allows us to annotate images like docker ones with labels and still keep the files in a single layer.

Fixes solo-io#292
kdorosh pushed a commit that referenced this issue Aug 23, 2022
* feat: changes the spec to support more than one layer

This allows us to annotate images like docker ones with labels and still keep the files in a single layer.

Fixes #292

* chore: fixes wording.

Co-authored-by: Takeshi Yoneda <[email protected]>

* chore: improves wording.

Co-authored-by: Takeshi Yoneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants