Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ModManager reading mod.ini in the mods folder #10

Open
thesupersonic16 opened this issue Oct 24, 2017 · 4 comments
Open

Issue with ModManager reading mod.ini in the mods folder #10

thesupersonic16 opened this issue Oct 24, 2017 · 4 comments

Comments

@thesupersonic16
Copy link
Collaborator

I haven't written an issue in a very long time.

So it looks like ManiaModManager is trying to load mod.ini from Sonic Mania/mods/mod.ini and is failing to substring the path.

The issue is that the ModManager is failing to substring the path for the key because its trying to get the directory name by removing the mods directory path plus a slash(I guess), which will not work if the mod.ini is in the mods directory, The exception is thrown at line 217 in MainForm.cs when mod.ini exists in the mods directory.

I have no idea if you wanted the mods directory to be a mod.

@MainMemory
Copy link
Member

No, there shouldn't be a mod.ini file in the mods folder. I don't know where you're getting one from, but it's not included with the mod loader.

@thesupersonic16
Copy link
Collaborator Author

Its not included, but some people are extracting mod.ini in their mods folder which causes the ModManager to throw an exception.

@MainMemory
Copy link
Member

Well then people should include the folder in their mod packages, like I do.

I guess I could try to add some kind of warning about having mod.ini in the mods folder.

@thesupersonic16
Copy link
Collaborator Author

That should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants