You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A while ago, @ValleyBell suggested some changes for the sound drivers of s1disasm, s2disasm, and skdisasm. The changes were that the labels be made more clear, and also follow some kind of standard between drivers. For example, each driver has a different label for UpdateDAC/zDACUpdateTrack/zUpdateDACTrack. He also suggested corrections for erroneous labels like cfHaltSound, which only halts music, and not necessarily all sound. While some changes are so black-and-white I could get away with making them, myself, I feel some of them need discussion first, such as the changing of cfPreventAttack to HoldNote, a change which would not only affect the drivers, but SMPS2ASM, and I feel my previous changing of cfAddKey to cfChangeTransposition was slightly unwelcome because of that.
The text was updated successfully, but these errors were encountered:
A while ago, @ValleyBell suggested some changes for the sound drivers of s1disasm, s2disasm, and skdisasm. The changes were that the labels be made more clear, and also follow some kind of standard between drivers. For example, each driver has a different label for UpdateDAC/zDACUpdateTrack/zUpdateDACTrack. He also suggested corrections for erroneous labels like cfHaltSound, which only halts music, and not necessarily all sound. While some changes are so black-and-white I could get away with making them, myself, I feel some of them need discussion first, such as the changing of cfPreventAttack to HoldNote, a change which would not only affect the drivers, but SMPS2ASM, and I feel my previous changing of cfAddKey to cfChangeTransposition was slightly unwelcome because of that.
The text was updated successfully, but these errors were encountered: