From 9f2c174c6ddb5382401890cc20f6774de23d445b Mon Sep 17 00:00:00 2001 From: gimhanul Date: Sun, 12 Nov 2023 17:42:05 +0900 Subject: [PATCH] delete: update user name --- .../simblue/domain/user/domain/User.java | 4 ---- .../user/presentation/TeacherController.java | 15 ++++----------- .../dto/request/UpdateStudentRequest.java | 3 --- .../user/service/UpdateStudentService.java | 2 -- .../user/service/UpdateTeacherService.java | 17 ----------------- 5 files changed, 4 insertions(+), 37 deletions(-) delete mode 100644 src/main/java/com/soogung/simblue/domain/user/service/UpdateTeacherService.java diff --git a/src/main/java/com/soogung/simblue/domain/user/domain/User.java b/src/main/java/com/soogung/simblue/domain/user/domain/User.java index 1da4e80..09b5076 100644 --- a/src/main/java/com/soogung/simblue/domain/user/domain/User.java +++ b/src/main/java/com/soogung/simblue/domain/user/domain/User.java @@ -58,10 +58,6 @@ public void updateStudentInformation(String studentNumber, Integer admissionYear this.admissionYear = admissionYear; } - public void updateName(String name) { - this.name = name; - } - public void updatePassword(String password) { this.password = password; } diff --git a/src/main/java/com/soogung/simblue/domain/user/presentation/TeacherController.java b/src/main/java/com/soogung/simblue/domain/user/presentation/TeacherController.java index 39d79a7..875c09c 100644 --- a/src/main/java/com/soogung/simblue/domain/user/presentation/TeacherController.java +++ b/src/main/java/com/soogung/simblue/domain/user/presentation/TeacherController.java @@ -2,13 +2,14 @@ import com.soogung.simblue.domain.user.domain.User; import com.soogung.simblue.domain.user.presentation.dto.request.TeacherRequest; -import com.soogung.simblue.domain.user.presentation.dto.request.UpdateTeacherRequest; import com.soogung.simblue.domain.user.service.JoinTeacherService; -import com.soogung.simblue.domain.user.service.UpdateTeacherService; import com.soogung.simblue.global.auth.annotation.AuthenticationPrincipal; import com.soogung.simblue.global.auth.annotation.Authority; import lombok.RequiredArgsConstructor; -import org.springframework.web.bind.annotation.*; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RequestBody; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; import javax.validation.Valid; @@ -18,7 +19,6 @@ public class TeacherController { private final JoinTeacherService joinTeacherService; - private final UpdateTeacherService updateTeacherService; @PostMapping public void joinTeacher( @@ -27,11 +27,4 @@ public void joinTeacher( joinTeacherService.execute(user, request); } - @PutMapping - public void updateTeacher( - @AuthenticationPrincipal(authority = Authority.TEACHER) User user, - @RequestBody @Valid UpdateTeacherRequest request - ) { - updateTeacherService.execute(user, request); - } } diff --git a/src/main/java/com/soogung/simblue/domain/user/presentation/dto/request/UpdateStudentRequest.java b/src/main/java/com/soogung/simblue/domain/user/presentation/dto/request/UpdateStudentRequest.java index f30530d..ca6724d 100644 --- a/src/main/java/com/soogung/simblue/domain/user/presentation/dto/request/UpdateStudentRequest.java +++ b/src/main/java/com/soogung/simblue/domain/user/presentation/dto/request/UpdateStudentRequest.java @@ -11,9 +11,6 @@ @AllArgsConstructor public class UpdateStudentRequest { - @NotBlank - private String name; - @NotBlank private String studentNumber; diff --git a/src/main/java/com/soogung/simblue/domain/user/service/UpdateStudentService.java b/src/main/java/com/soogung/simblue/domain/user/service/UpdateStudentService.java index dba82d8..3d2fe88 100644 --- a/src/main/java/com/soogung/simblue/domain/user/service/UpdateStudentService.java +++ b/src/main/java/com/soogung/simblue/domain/user/service/UpdateStudentService.java @@ -12,8 +12,6 @@ public class UpdateStudentService { @Transactional public void execute(User user, UpdateStudentRequest request) { - user.updateName(request.getName()); - user.updateStudentInformation(request.getStudentNumber(), request.getAdmissionYear()); } } diff --git a/src/main/java/com/soogung/simblue/domain/user/service/UpdateTeacherService.java b/src/main/java/com/soogung/simblue/domain/user/service/UpdateTeacherService.java deleted file mode 100644 index 43e7ce5..0000000 --- a/src/main/java/com/soogung/simblue/domain/user/service/UpdateTeacherService.java +++ /dev/null @@ -1,17 +0,0 @@ -package com.soogung.simblue.domain.user.service; - -import com.soogung.simblue.domain.user.domain.User; -import com.soogung.simblue.domain.user.presentation.dto.request.UpdateTeacherRequest; -import lombok.RequiredArgsConstructor; -import org.springframework.stereotype.Service; -import org.springframework.transaction.annotation.Transactional; - -@Service -@RequiredArgsConstructor -public class UpdateTeacherService { - - @Transactional - public void execute(User user, UpdateTeacherRequest request) { - user.updateName(request.getName()); - } -}