Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename various equality methods for Statements #441

Open
bgyori opened this issue Mar 21, 2018 · 0 comments
Open

Rename various equality methods for Statements #441

bgyori opened this issue Mar 21, 2018 · 0 comments
Assignees
@bgyori
Milestone
Refactoring

Comments

@bgyori
Copy link
Member

bgyori commented Mar 21, 2018 •
edited
Loading

Currently we have equals, matches, entity_matches methods for Statements to check different kinds of equality in different situations (in addition to __eq__ of course, which we reserve for object-reference equality). It would be good to give more descriptive names to these methods, for instance

  • equals -> evidence_matches
  • matches -> mechanism_matches
  • entity_matches -> entities_match
@johnbachman johnbachman added this to the Refactoring milestone Apr 4, 2018
@bgyori bgyori self-assigned this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgyori bgyori

Labels
None yet
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
2 participants
@johnbachman @bgyori