Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of ptr::Unique and ptr::Shared with ptr::NonNull #111

Open
hawkw opened this issue Jan 23, 2018 · 3 comments
Open

Replace uses of ptr::Unique and ptr::Shared with ptr::NonNull #111

hawkw opened this issue Jan 23, 2018 · 3 comments
Labels
contrib/easy Contributing: this issue likely requires less time or experience than other issues. contrib/good first issue Contributing: this issue would make a good starting point for a first-time contributor. kind/refactor Kind: this issue describes refactoring or code quality improvement.
Milestone
build is still on...

Comments

@hawkw
Copy link
Member

hawkw commented Jan 23, 2018 •
edited
Loading

These types were renamed recently in the standard lib. For context, see also sos-os/alarm#12, sos-os/alarm#25.
@hawkw hawkw added kind/bug Kind: this issue is a bug. contrib/easy Contributing: this issue likely requires less time or experience than other issues. critical contrib/good first issue Contributing: this issue would make a good starting point for a first-time contributor. labels Jan 23, 2018
@hawkw
Copy link
Member Author

hawkw commented Jan 23, 2018

This should be more or less trivial; just a find and replace. Will fix the build, though, so that's big!

hawkw added a commit that referenced this issue Jan 24, 2018
@hawkw
fix(sos_intrusive): temp fix for #111
8127f55
hawkw added a commit that referenced this issue Jan 24, 2018
@hawkw
fix(vga): temporary fix for #111
b27040a
@hawkw hawkw removed the critical label Jan 24, 2018
hawkw added a commit that referenced this issue Jan 24, 2018
@hawkw
fix(sos_intrusive): temp fix for #111
847c308
hawkw added a commit that referenced this issue Jan 24, 2018
@hawkw
fix(vga): temporary fix for #111
c84ca3b
@hawkw
Copy link
Member Author

hawkw commented Jan 24, 2018 •
edited
Loading

The #![feature(ptr_internals)] flags added in 847c308 and c84ca3b should also be removed when fixing this.

@hawkw hawkw added kind/refactor Kind: this issue describes refactoring or code quality improvement. and removed kind/bug Kind: this issue is a bug. labels Jan 24, 2018
@hawkw
Copy link
Member Author

hawkw commented Jan 24, 2018

No longer critical or bug as this no longer breaks the build after 847c308 and c84ca3b, but referring to this type by its old name is still deprecated & should be changed.

@hawkw hawkw added this to the build is still on fire milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib/easy Contributing: this issue likely requires less time or experience than other issues. contrib/good first issue Contributing: this issue would make a good starting point for a first-time contributor. kind/refactor Kind: this issue describes refactoring or code quality improvement.
Projects
None yet
Milestone
build is still on fire
Development

No branches or pull requests
1 participant
@hawkw