Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add some networking related command outputs #3708

Open
jeditransistor opened this issue Jul 17, 2024 · 3 comments
Open

[RFE] Add some networking related command outputs #3708

jeditransistor opened this issue Jul 17, 2024 · 3 comments

Comments

@jeditransistor
Copy link

NIC related
FEC:
$ ethtool --show-fec
EEE:
$ ethtool --show-eee
ntuple-filters / Flow director:
// Can also use -u
$ ethtool --show-ntuple

For supportconfig ONLY:
$ ethtool --show-coalesce

XPORT
Socket statistics:
$ ss -s
IPv6 statistics:
$ netstat -s -6

@jcastill
Copy link
Member

Thank you for opening this RFE! Some notes:

  • We already capture EEE via:

"ethtool --show-eee %(dev)s",

In the networking.py plugin, so I imagine that that one doesn't need any modification.

  • "ethtool --show-fec" - applies to ethernet devices, like --show-eee as well?
  • All these 'ethtool' commands need a device name, right?

The last two commands are straightforward to add - we only capture ss -peaonmi at the moment and netstat -s . I'll start with these while we get clarification on the ethtool ones.

jcastill added a commit to jcastill/sos that referenced this issue Jul 17, 2024
Capture more ethtool, ss, and netstat command
outputs.

Related: sosreport#3708

Signed-off-by: Jose Castillo <[email protected]>
@pmoravec
Copy link
Contributor

The commands (with expected device names, I guess):

ethtool --show-fec %(dev)
ethtool --show-ntuple %(dev)
ethtool --show-coalesce %(dev)

they 1) provide some additional information not already collected by other commands? 2) do not load a kernel module for their execution, and they dont start a service? 3) they can't get stuck their own execution neither get stuck some networking devices under some specific situations (cf. e.g. https://github.com/sosreport/sos/blob/main/sos/report/plugins/networking.py#L188-L195)?

@thierry-schwertz
Copy link

I am the one that have asked this enhancement through RedHat.
1/ You do not need to add: ethtool --show-coalesce %(dev)
This is already collected through ethtool -c %(dev)
This request was for supportconfig (SLES)
2/ Yes you are right you need to provides interface name '%(dev)'
3/ Yes, "ethtool --show-fec" - applies to ethernet devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants