Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upload] The upload feature should support uploading multiple files #3905

Open
pmoravec opened this issue Jan 16, 2025 · 1 comment
Open

Comments

@pmoravec
Copy link
Contributor

pmoravec commented Jan 16, 2025

A requirement originating from #3746 (comment): sos upload should allow uploading multiple files.

I prefer implementing this enhancement as a PR separate from the Jose's or Jake's ones, since its implementation will depend on the final class hierarchy and I prefer "layered" approach in adding functionality - it is better for PR authors and reviews to keep PRs smaller.

sos upload FILE1 FILE2 .. FILEn should determine a target / protocol / URL / credentials / .., authenticate there and then simply upload one file after another.

How to deal when say 3rd file out of five will fail to upload? Shall we continue in upload of remaining files or abort? (in either case, we must explicitly list all the files that failed to be uploaded)

And should we allow concurrent files upload..?

@pmoravec pmoravec changed the title [upload] The upload feature should support uploading mutliple files [upload] The upload feature should support uploading multiple files Jan 22, 2025
@jcastill
Copy link
Member

sos upload FILE1 FILE2 .. FILEn should determine a target / protocol / URL / credentials / .., authenticate there and then simply upload one file after another.

How to deal when say 3rd file out of five will fail to upload? Shall we continue in upload of remaining files or abort? (in either case, we must explicitly list all the files that failed to be uploaded)

Lets say we have 5 files and 1 or 2 fail. If the failure is due to an issue in the remote target, and not because it's an empty file, or a file that doesn't exist, then I think we should, in order:
1- Attempt to upload the file N times before failing completely (with a very low N, and a time between retries)
2- List the files that uploaded successfully and the ones that failed at the end.

It's more useful for our support guys to have something to start the analysis, than having to wait for 5 files because a number of them couldn't be uploaded.

And should we allow concurrent files upload..?

Depends on the target. I'll have a chat with our customer portal team to see what they allow and prefer.
Anyway I'd like to work on this PR later on if nobody opposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants