Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tab autohide no longer works with Nightly 135 #207

Open
dreadbalaur opened this issue Dec 7, 2024 · 60 comments
Open

Vertical tab autohide no longer works with Nightly 135 #207

dreadbalaur opened this issue Dec 7, 2024 · 60 comments
Labels
revisit wip Work in progress. No time table set.

Comments

@dreadbalaur
Copy link

Describe the issue:

The autohide animation no longer works after this update. The sidebar button now toggles between hiding and expanding the vertical tabs. ultima.tabs.autohide now toggles between the collapsed and expanded states of the tabs. Sidebar autohide animation still works.

Platform/Desktop:

  • OS: Windows 10 22H2
  • Browser Version: Nightly 135 (December 6 update)
@soulhotel
Copy link
Owner

Will work on it in a day, once I have time to spare.

@soulhotel soulhotel pinned this issue Dec 7, 2024
@dreadbalaur
Copy link
Author

No rush. Just figured it's better to notify you asap.

@soulhotel soulhotel added revisit wip Work in progress. No time table set. labels Dec 12, 2024
@soulhotel
Copy link
Owner

So I noticed.. When hovering the vertical tabs with auto-hide on, the sidebar is being unusually forced into its collapsed state. This is scripted inline - into the elements behavior. Which means I can't override it with userChrome.

IDK what firefox developers are aiming for here, but it is pretty frustrating. Maybe this will be doable in a future Nightly update, hopefully this isn't included in the next Firefox versions, I'll keep working at it and see what can be done. Otherwise tab auto-hiding will have to be disabled....

2024-12-11.22-14-55.mp4

@soulhotel
Copy link
Owner

@jjcortes22 found out that it works when you disable/enable vertical tabs from settings. This works until you restart the Browser.

Vert.tab.issue.mp4

What a headache.

@dreadbalaur
Copy link
Author

That's quite frustrating then. Instead of giving us native autohide they tweaked it for... no particular use?

@soulhotel
Copy link
Owner

Alright... It's a result of the new sidebar splitter. Once the vertical tabs fall below 100px, the sidebar is forced into a collapsed state. This is meant to work hand in hand with the new sidebar splitter that lets you resize the vertical tabs manually. This obviously can't work with autohiding because to autohide, the tabs would need to shrink to the collapsed state as well.

Fortunately there is another way to do Autohiding - by sliding the vertical tabs from left-to-right without manipulating the width. Unfortunately this would also mean completely hiding them when not hovered, instead of the icon only view.

Nightly:

2024-12-11.23-19-35.mp4

I really hope this isn't what I have to do, the collapsing into the icon view is very helpful (visually) but if this is the direction Firefox goes then it will be better than no auto-hiding.

@soulhotel
Copy link
Owner

That's quite frustrating then. Instead of giving us native autohide they tweaked it for... no particular use?

Yeah..

@soulhotel
Copy link
Owner

The fix is in. This will all be handled via the nightly.override setting, so have it enabled.

@jjcortes22
Copy link

Thank you so much, I will upgrade after a dr appointment.
Is there a way I can dm you? @soulhotel

@soulhotel
Copy link
Owner

Also, the tabs-width Settings will not work with nightly.override. Vertical Tabs can be resized by turning auto-hiding off, then dragging the sidebar to desired width.

@jjcortes22 Don't think you can on github, what did you want to discuss?

@jjcortes22
Copy link

Also, the tabs-width Settings will not work with nightly.override. Vertical Tabs can be resized by turning auto-hiding off, then dragging the sidebar to desired width.

@jjcortes22 Don't think you can on github, what did you want to discuss?

Hi, nothing really, just wanna give you a little something, I notice nowhere in your page I can give you donations or anything.

This thing you make for ff is great, i love the fact i dont need sidebery.

@soulhotel
Copy link
Owner

@jjcortes22 appreciate the consideration, truly. Funny because, I used to be a Sidebery-or-Nothing type of person, but when I learned how to use CSS in Sidebery, I just couldn't stop there, ending up trying to make the Ultimate version of Firefox.

But this whole project is just suppose to be another hobby. I feel, if I take donations then it makes my work on it into a "Job" (with expectations, performance quotas, etc). Then again, the amount of hours that go into maintaining it definitely take away from everything else I have going on; It pretty much already is a Job. Maybe I won't have an issue with donations some day, idk. Either way, thanks.

@jjcortes22
Copy link

Well, thank you again for what you do.

@jjcortes22
Copy link

I just patched to the last version and still wont work for me. I have to get very slowly to the edge of my browser for the tabs to slide.

2024-12-13.22-18-14.mp4

Am I doing something wrong?

@soulhotel
Copy link
Owner

This code below is lines 515-519 of chrome/theme/nightly-override.css.

/* visibility trigger */
#sidebar-main:has([expanded])::after {
content: "";background-color:none;position: fixed;
z-index: 9999;top: var(--uc-topbars-combined-height);left: 0;width: 3px;height: 100vh;
}

  • Currently, the Vertical tabs hover trigger is set to 3px, meaning you need to be within 3px's of the screen-edge to trigger the Tabs.
  • I could set it to 5px or even 15px, but it depends on how sensitive someone may want the trigger to be. It could block you from clicking something on a page if you ever needed to click around there.
/* visibility trigger */ 
 #sidebar-main:has([expanded])::after { 
     content: "";background-color:none;position: fixed; 
     z-index: 9999;top: var(--uc-topbars-combined-height);left: 0;width: 15px;height: 100vh; 
 } 

@soulhotel
Copy link
Owner

soulhotel commented Dec 14, 2024

For now, I changed it to 15px. Feel free to increase/decrease to something you prefer. Here's the updated nightly-override.css file.

2024-12-14.00-00-00.mp4

Also, why the hell is your Desktop so Cinematic!

@jjcortes22
Copy link

Changed to 15px and works great, thank you.

@rush1644
Copy link

Hey, how do we patch to the latest version? I made sure my nightly.override was set to true, what else do I need to do? Thanks!

@soulhotel
Copy link
Owner

@rush1644 just get the 1.9.7 release

https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.9.7

@dreadbalaur
Copy link
Author

dreadbalaur commented Dec 15, 2024

Nice! I will test it out. Also for ultima.navbar.autohide - does firefox allows any options to drag the window around when navbar is hidden? This is probably the one thing that keeps me from using that feature more.

Edit: it's working for me. However, is there a way to trigger autohide between collapsed and expanded states? Right now if I want to enable autohide I am stuck between hidden and expanded.

@astrologiical
Copy link

For now, I changed it to 15px. Feel free to increase/decrease to something you prefer. Here's the updated nightly-override.css file.
2024-12-14.00-00-00.mp4

Also, why the hell is your Desktop so Cinematic!

how do I change the px?

@dreadbalaur
Copy link
Author

For now, I changed it to 15px. Feel free to increase/decrease to something you prefer. Here's the updated nightly-override.css file.
2024-12-14.00-00-00.mp4
Also, why the hell is your Desktop so Cinematic!

how do I change the px?

Look for this section in nightly-override.css, and change the width. By default it is now set at 15px.

/* visibility trigger */ 
 #sidebar-main:has([expanded])::after { 
     content: "";background-color:none;position: fixed; 
     z-index: 9999;top: var(--uc-topbars-combined-height);left: 0;width: 15px;height: 100vh; 
 } 

@astrologiical
Copy link

astrologiical commented Dec 15, 2024

For now, I changed it to 15px. Feel free to increase/decrease to something you prefer. Here's the updated nightly-override.css file.
2024-12-14.00-00-00.mp4
Also, why the hell is your Desktop so Cinematic!

how do I change the px?

Look for this section in nightly-override.css, and change the width. By default it is now set at 15px.

/* visibility trigger */ 
 #sidebar-main:has([expanded])::after { 
     content: "";background-color:none;position: fixed; 
     z-index: 9999;top: var(--uc-topbars-combined-height);left: 0;width: 15px;height: 100vh; 
 } 

I don't know where to put the nightly override file and/or edit it

@soulhotel
Copy link
Owner

@astrologiical just redownload the 1.9.7 release, its updated with the corrections.

@dreadbalaur dragging the window,with navbar-autohide, works on Windows

it's working for me. However, is there a way to trigger autohide between collapsed and expanded states? Right now if I want to enable autohide I am stuck between hidden and expanded.

Are you talking about this?

image

@astrologiical
Copy link

@astrologiical just redownload the 1.9.7 release, its updated with the corrections.

@dreadbalaur dragging the window,with navbar-autohide, works on Windows

it's working for me. However, is there a way to trigger autohide between collapsed and expanded states? Right now if I want to enable autohide I am stuck between hidden and expanded.

Are you talking about this?

image

i have downloaded the new one, just wondering how to make the sidebar wider

@astrologiical
Copy link

astrologiical commented Dec 15, 2024

@astrologiical
2024-12-14.23-09-56.mp4

i was referring to the sidebar in it's resting state - i may have misunderstood what you meant in the previous message though

@dreadbalaur
Copy link
Author

@soulhotel my sidebar button is already set to expanding/collapsing the sidebar. I'm talking about the current ultima.tabs.autohide behaviour: the setting only works when the sidebar is in expanded state (as usual) and the animation toggles between the fully expanded state and a fully hidden state. I would prefer to have autohide changes between an expanded and collapsed state like previously.

I would appreciate it if there is a way to customize the slide-in/slide-out speed too. The current animation is a tad bit too fast for my preference.

@dreadbalaur
Copy link
Author

@astrologiical
2024-12-14.23-09-56.mp4

i was referring to the sidebar in it's resting state - i may have misunderstood what you meant in the previous message though

Can you elaborate on what you are referring to as the "resting state"? You meant the collapsed state of the sidebar with only the website icon visible?

@astrologiical
Copy link

@astrologiical
2024-12-14.23-09-56.mp4

i was referring to the sidebar in it's resting state - i may have misunderstood what you meant in the previous message though

Can you elaborate on what you are referring to as the "resting state"? You meant the collapsed state of the sidebar with only the website icon visible?

I mean the line that when you hover your mouse over, it opens up and shows you the tab

@soulhotel
Copy link
Owner

@astrologiical its the 1.9.7 release has already been updated with the 15px sensitivity fix. If you still need help with that make a new seperate issue.

@dreadbalaur the container tabs has been fixed, had a typo in the code in theme-xstyle.css.

@dreadbalaur

my sidebar button is already set to expanding/collapsing the sidebar. I'm talking about the current ultima.tabs.autohide behaviour: the setting only works when the sidebar is in expanded state (as usual) and the animation toggles between the fully expanded state and a fully hidden state. I would prefer to have autohide changes between an expanded and collapsed state like previously.

for the vertical tabs collapsed appearance, like i said above:

It's a result of the new sidebar splitter. Once the vertical tabs fall below 100px, the sidebar is forced into a collapsed state. This is meant to work hand in hand with the new sidebar splitter that lets you resize the vertical tabs manually. This obviously can't work with auto-hiding because to auto-hide, the tabs would need to shrink to the collapsed state as well.

Before my implementation of Auto-hiding was simple, I would just shrink the width of the Sidebar to 50px (icons only) when not hovered. If you try to do that now, then the Sidebar will be forced into the built-in collapsed state (meaning you have to press the sidebar button to put it back in the expanded state. This new change creates a loop where the collapsed state continuously overtakes the expanded state, rendering the auto-hide feature as broken. This is the original issue, the topic of your post.

TLDR: Firefox's scripted behavior in the 135 update, overrides the expanded vertical tabs width when using auto-hiding.

I tried a difference approach as well:

Making the sidebar 50px (icon-only) is impossible so.. I shrunk it to 100px instead (maximum allowed before it gets forced into the built-in collapsed state)... Then push the tabs, pinned tabs, mini toolbar to the side. Looks almost identical to the original design, doesn't look like I changed anything here, right?

2024-12-15.23-11-19.mp4

But this doesn't work.

  • If you sidebar button once.
  • Or turn autohiding off/on.
  • Or change the width of the vertical tabs in the settings
  • Or trigger the other sidebar (which forces vertical tabs to collapse)

It breaks.

2024-12-15.23-22-00.mp4
  • You have to go into about:config,
  • turn autohiding off,
  • turn the width setting off,
  • press the sidebar button to make it expanded,
  • turn autohiding back on,
  • then set width again. To fix it.

So sliding them in and out of view without changing the width will have to be the solution.


I spent a couple of hours last-night, even though I had work in the morning (just getting back a while ago)... trying to see what type of combinations/methods I could use to override this update. I ended up throwing away those hours of work because nothing was getting it done. If I can get it back to the old style that would be the best, but it's probably not going to happen right now.

@dreadbalaur
Copy link
Author

That makes sense, but it is a shame. Thank you for the detailed breakdown.

@soulhotel
Copy link
Owner

Np, it really is a dissappointment.

I really hope Firefox does the autohiding on their own soon, because I hate not being able to see the icons. And If anything you can use Developer Edition and still have the icons until it reaches that Nightly update. That's what I'm doing. And it shouldn't reach that update for at least another 20-30 days depending on whenever you first encountered this change.

@soulhotel
Copy link
Owner

Update:

In regards to keeping the autohidden state working with an icon-only view:

  • A solution proposed by @tthornton3-chwy, is to use autoconfig. It requires some initial setup, but once done you'd simply need all of the necessary files in the chrome folder.

  • Another method that involves shrinking the tabs to 100px when autohidden, and overlaying the browser-content over it. Just replace userChrome.css with nightly-override off.

FF-ULTIMA/userChrome.css

Lines 33 to 37 in 72e81ac

@media not (-moz-bool-pref: "nightly-override") {
:root {--uc-vertical-collapsed-width:101px;}
#sidebar-main:has([expanded]):not(:hover) ~ #tabbrowser-tabbox {z-index:10000 !important;}
}

I don't know how viable this one will end up be, but it seems to be working with the tabs width settings. So good for now.

@dreadbalaur
Copy link
Author

I could not follow what the link to method 1 was saying, where can I find sidebarAutoHide.uc.js:19?

@tthornton3-chwy
Copy link
Contributor

tthornton3-chwy commented Dec 19, 2024

Method 1 instructions!

  1. Have the theme up and working, on the update branch!
    a. If it's been a bit since you've set it up, you may want to either:
  2. Do steps #1, #6, and #7 from here https://github.com/xiaoxiaoflood/firefox-scripts?tab=readme-ov-file#instructions
  3. Make sure ultima.tabs.autohide is on in about:config, and you're all set!

By the end of this you should have a new icon for userChrome.js Manager, which has a Sidebar Auto-Hide option enabled. And sidebar auto-hiding working again!

@soulhotel
Copy link
Owner

So I actually found a great way to handle the 135 update, I just needed to dumb it down a bit and the answer was obvious.. I mentioned before, trying to shrink the vertical tabs to 100px, to avoid the scripted state-adjustment. If I apply that to the vt sidebar #sidebar-main { 101px }, while keeping everything inside #sidebar-main * { 56px }. It get's the job done.

FF-ULTIMA/userChrome.css

Lines 34 to 50 in 0688d2e

@media not (-moz-bool-pref: "nightly-override") {
@media (-moz-bool-pref: "ultima.tabs.autohide") {
/* the verttab container (collapsed width) should now be >100px to escape the scripted state behavior of firefox */
:root {--uc-vertical-collapsed-width: 101px;}
/* but the content inside of the verttab container should remain how it was, 56px works */
#sidebar-main * {--uc-vertical-collapsed-width: 56px !important;}
/* the tabbrowsertabbox (browser content) needs to overlay the extra unused verttab container space, when not hovered */
#sidebar-main:has(#tabbrowser-tabs[expanded]):not(:hover) ~ #tabbrowser-tabbox {z-index: 1000 !important;}
/* the verttab container should not overlay browser content when it is in firefox's built-in collapsed-state */
#sidebar-main:not(:has(#tabbrowser-tabs[expanded])) {z-index: 0 !important;}
}
}

This is Nightly with nightly.override no longer needed:

2024-12-19.09-55-24.mp4

Update Branch

Now, Because the vertical tabs are actually 100px (when not hovered) due to the extra space (that you don't see) hidden behind the browser content, the animation looks like it stutters at the 100px mark. But it works. Let me know your thoughts on this, when you get a chance. @tthornton3-chwy @dreadbalaur

@tthornton3-chwy
Copy link
Contributor

Oooo nice one @soulhotel!! This definitely works! You're right, I do also see some stuttering with this method vs the other, but it's negligible, and this being the default solution makes sense.

One thing of note:
Screenshot 2024-12-19 at 12 12 10 PM

My back button disappears with this method, when in full-screen 😲 I made the bar red to highlight, I think it's probably solvable with z-indexes or transparencies or some sort, but worth pointing out (and currently on the clock so can't do more atm haha)! I can in theory get it to keep showing my enabling ultima.tabs.belowURLbar but then there's way too much space between the sidebar and the the navigation bar 😢 :
Screenshot 2024-12-19 at 12 16 01 PM

@soulhotel
Copy link
Owner

Fixed. I changed the navbar padding (when fullscreened) to a static number, instead of --uc-vertical-collapsed-width, while I was working through this whole 135 issue.

code

new

/* browser space adjustments */
@media (-moz-bool-pref: "sidebar.revamp") {
#main-window:not([inDOMFullscreen="true"]) #browser:not(:has(#sidebar-main[hidden="true"])) {
margin-left:50px !important;
}
#main-window:not([inDOMFullscreen="true"]) #browser:not(:has(#sidebar-main[hidden="true"],#sidebar-splitter[hidden="true"])) {
margin-left:55px !important;
}
#main-window[inFullscreen="true"] {
#sidebar-main {top:-3px !important; height:100vh !important; }
#navigator-toolbox:has(+ #browser > #sidebar-main:not([hidden="true"])) {padding-left: var(--uc-vertical-collapsed-width);}
}
}

old

/* browser space adjustments */
@media (-moz-bool-pref: "sidebar.revamp") {
#main-window:not([inDOMFullscreen="true"]) #browser:not(:has(#sidebar-main[hidden="true"])) {
margin-left:50px !important;
}
#main-window:not([inDOMFullscreen="true"]) #browser:not(:has(#sidebar-main[hidden="true"],#sidebar-splitter[hidden="true"])) {
margin-left:55px !important;
}
#main-window[inFullscreen="true"] {
#sidebar-main {top:0 !important; height:100vh !important; }
#navigator-toolbox:has(+ #browser > #sidebar-main:not([hidden="true"])) {padding-left: 55px;}
}
}

Using z-index here would mean cutting off the top of the sidebar and/or making it adjust width when the navigation bar is hovered, for simplicity I'll just stick to moving the content to the side when full screen.

image

@soulhotel
Copy link
Owner

soulhotel commented Dec 19, 2024

Yeah so I'll have this be the solution,

Now I really need to clean up, because this issue definitely causes confusion. I'm going to make two new settings:

  • ultima.enable.js.config

  • ultima.enable.nightly.config

  • With js config this solution will not be applied, so that the script you merged will be usable for people that want to get rid of the stutter. And any future autoconfig features that include css can be easily seperated/organized within the setting if needed.

  • With nightly config the setting wont be needed after this, but any future nightly updates that need a quick patch can be organized here. nightly.override can be deleted.

  • The naming allows both settings to be at the top of the aboutconfig page when searching for ultima


Edit:
(good on default, dev, and nightly)

2024-12-19.14-27-54.mp4

@dreadbalaur
Copy link
Author

Working like a charm on my end! Kudos to you @soulhotel

@jjcortes22
Copy link

Hi, Sorry to necrodump this, i reinstalled 1.9.7 and wont work, What is the ultimate setting?
I just deleted the chrome folder, created a new one and followed the "difficult installation".

@soulhotel
Copy link
Owner

Download the theme's source since these changes won't be announced or packaged until the next release (1.9.7 isn't updated with the fix). So:

  1. ⬇️ Source Download Here or....

image

  1. Since downloading the Source generates an extra folder, open that ff-ultima folder, then copy the files inside, into your chrome folder.

image

image

  1. You can add the setting ultima.enable.nightly.config manually on the about:config page, or use the user.js to get the setting.
  • nightly.override will no longer matter / can be deleted

  • When I package release zips, I remove the .git folder and license, for the future I'll be removing the us.js files and utils folder as well. So you can definitely just delete those for now and you won't have to deal with those extra steps again.

@soulhotel
Copy link
Owner

So once you download the source, and put the files in chrome, just have ultima.enable.nightly.config on.

@dreadbalaur
Copy link
Author

Download the theme's source since these changes won't be announced or packaged until the next release (1.9.7 isn't updated with the fix). So:

1. **[⬇️ Source Download Here](https://github.com/soulhotel/FF-ULTIMA/archive/refs/heads/main.zip)**  or....

image

2. Since downloading the Source generates an extra folder, open that ff-ultima folder, then copy the files inside, into your chrome folder.

image

image

3. You can add the setting `ultima.enable.nightly.config` manually on the about:config page, or use the user.js to get the setting.


* `nightly.override` will no longer matter / can be deleted

* When I package release zips, I  remove the `.git` folder and `license`, for the future I'll be removing the `us.js` files and `utils` folder as well. So you can definitely just delete those for now and you won't have to deal with those extra steps again.

Aside from the new rebuild_userChrome.uc.js and sidebarAutoHide.uc.js, are there any changes to the other files from 1.9.7?

@soulhotel
Copy link
Owner

https://github.com/soulhotel/FF-ULTIMA/blob/main/change-log.md

  • website-newtab.css - for new tab shortcuts patch
  • theme-audio-indicator.css - for your earlier issue
  • nightly-override.css - removed
  • all-global-config.css - to handle nightly configs and autoconfig settings

I could be missing something but the change Log in the source has whats different, and the main branch is up to date.

@dreadbalaur
Copy link
Author

Thanks. And are the new javascripts placed in the chrome folder? Or should they be placed outside like user.js?

@soulhotel
Copy link
Owner

They dont need to be moved, if you aren't using autoconfig you just need the userchrome.css, usercontent.css and theme folder.

I'll package everything up for you guys when I get home in a few hours.

@jjcortes22
Copy link

jjcortes22 commented Dec 22, 2024

Hi,

I just

Download the theme's source since these changes won't be announced or packaged until the next release (1.9.7 isn't updated with the fix). So:

1. **[⬇️ Source Download Here](https://github.com/soulhotel/FF-ULTIMA/archive/refs/heads/main.zip)**  or....

image

2. Since downloading the Source generates an extra folder, open that ff-ultima folder, then copy the files inside, into your chrome folder.

image

image

3. You can add the setting `ultima.enable.nightly.config` manually on the about:config page, or use the user.js to get the setting.


* `nightly.override` will no longer matter / can be deleted

* When I package release zips, I  remove the `.git` folder and `license`, for the future I'll be removing the `us.js` files and `utils` folder as well. So you can definitely just delete those for now and you won't have to deal with those extra steps again.

Hi,

I just downloaded it, copied the content inside my chrome folder, checked and made sure "ultima.enable.nightly.config" was enabled and basically I have to apply the same workaround as before, go to settings, disable vert tabs, re-enable vert tabs under firefox labs and it works, it wont out of the box.

@soulhotel
Copy link
Owner

It's been packaged, at the bottom of the 1.9.7 release page as ffultima1.9.7.207.zip.

https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.9.7

image

@jjcortes22
Copy link

jjcortes22 commented Dec 23, 2024

It's been packaged, at the bottom of the 1.9.7 release page as ffultima1.9.7.207.zip.

https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.9.7

image

Hi,

I just downloaded the 207 zip file, extracted all the content, copied everything inside my chrome folder, restarted firefox, Still have to disable and re enable the vertical tabs in firefox labs for the tabs to expand.
I dont know if I am doing something wrong.

Thanks for updating it tho.

@soulhotel
Copy link
Owner

Dont get what would prompt that behavior, haven't run into it on Linux or Windows.

@dreadbalaur
Copy link
Author

Just tested the new package - behaviour is not too different from the unpackaged version I tested earlier, but I'm not sure what ultima.enable.js.config is for as tab autohide only works with it disabled.

@jjcortes22 is user.js in the profile folder (1 parent up from the chrome folder) and then deleted? And what is your current about:config setting?

@jjcortes22
Copy link

Hey Guys, first of all, thank you so much for not letting me die here.

@dreadbalaur I forgot to move the user.js to the profile folder, I did that and also checked "ultima.enable.js.config" make sure it was set to false and things seem to work now.

Completely my fault, forgot to move the user.js, open, then delete it.

@soulhotel Thanks for continued development.

@soulhotel
Copy link
Owner

  • js.config is a setting needed only if you use Autoconfig, like documented above.
  • The nightly.config setting will be for any patches needed for future issues that occur in new nightly updates.

You can disable both and it should be as if the 135 update didn't happen.

@soulhotel
Copy link
Owner

soulhotel commented Dec 23, 2024

At the moment, js.config will basically undo the fixes I made for nightly. This lets autoconfig users use the included uc.js files to get the previously smoother/fluid animation of the autohiding. So again, you can leave both the config settings disabled, and if new fixes for Nightly are ever needed, they will be handled through the nightly.config setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revisit wip Work in progress. No time table set.
Projects
None yet
Development

No branches or pull requests

6 participants