-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical tab autohide no longer works with Nightly 135 #207
Comments
Will work on it in a day, once I have time to spare. |
No rush. Just figured it's better to notify you asap. |
So I noticed.. When hovering the vertical tabs with auto-hide on, the sidebar is being unusually forced into its collapsed state. This is scripted inline - into the elements behavior. Which means I can't override it with userChrome. IDK what firefox developers are aiming for here, but it is pretty frustrating. Maybe this will be doable in a future Nightly update, hopefully this isn't included in the next Firefox versions, I'll keep working at it and see what can be done. Otherwise tab auto-hiding will have to be disabled.... 2024-12-11.22-14-55.mp4 |
@jjcortes22 found out that it works when you disable/enable vertical tabs from settings. This works until you restart the Browser. Vert.tab.issue.mp4What a headache. |
That's quite frustrating then. Instead of giving us native autohide they tweaked it for... no particular use? |
Alright... It's a result of the new sidebar splitter. Once the vertical tabs fall below 100px, the sidebar is forced into a collapsed state. This is meant to work hand in hand with the new sidebar splitter that lets you resize the vertical tabs manually. This obviously can't work with autohiding because to autohide, the tabs would need to shrink to the collapsed state as well. Fortunately there is another way to do Autohiding - by sliding the vertical tabs from left-to-right without manipulating the width. Unfortunately this would also mean completely hiding them when not hovered, instead of the icon only view. Nightly: 2024-12-11.23-19-35.mp4I really hope this isn't what I have to do, the collapsing into the icon view is very helpful (visually) but if this is the direction Firefox goes then it will be better than no auto-hiding. |
Yeah.. |
The fix is in. This will all be handled via the |
Thank you so much, I will upgrade after a dr appointment. |
Also, the
|
Hi, nothing really, just wanna give you a little something, I notice nowhere in your page I can give you donations or anything. This thing you make for ff is great, i love the fact i dont need sidebery. |
@jjcortes22 appreciate the consideration, truly. Funny because, I used to be a Sidebery-or-Nothing type of person, but when I learned how to use CSS in Sidebery, I just couldn't stop there, ending up trying to make the Ultimate version of Firefox. But this whole project is just suppose to be another hobby. I feel, if I take donations then it makes my work on it into a "Job" (with expectations, performance quotas, etc). Then again, the amount of hours that go into maintaining it definitely take away from everything else I have going on; It pretty much already is a Job. Maybe I won't have an issue with donations some day, idk. Either way, thanks. |
Well, thank you again for what you do. |
I just patched to the last version and still wont work for me. I have to get very slowly to the edge of my browser for the tabs to slide. 2024-12-13.22-18-14.mp4Am I doing something wrong? |
This code below is lines 515-519 of chrome/theme/ FF-ULTIMA/theme/nightly-override.css Lines 515 to 519 in 7da10d9
|
For now, I changed it to 15px. Feel free to increase/decrease to something you prefer. Here's the updated nightly-override.css file. 2024-12-14.00-00-00.mp4Also, why the hell is your Desktop so Cinematic! |
Changed to 15px and works great, thank you. |
Hey, how do we patch to the latest version? I made sure my nightly.override was set to true, what else do I need to do? Thanks! |
@rush1644 just get the 1.9.7 release |
Nice! I will test it out. Also for Edit: it's working for me. However, is there a way to trigger autohide between collapsed and expanded states? Right now if I want to enable autohide I am stuck between hidden and expanded. |
how do I change the px? |
Look for this section in nightly-override.css, and change the width. By default it is now set at 15px.
|
I don't know where to put the nightly override file and/or edit it |
@astrologiical just redownload the 1.9.7 release, its updated with the corrections. @dreadbalaur dragging the window,with navbar-autohide, works on Windows
Are you talking about this? |
i have downloaded the new one, just wondering how to make the sidebar wider |
i was referring to the sidebar in it's resting state - i may have misunderstood what you meant in the previous message though |
@soulhotel my sidebar button is already set to expanding/collapsing the sidebar. I'm talking about the current I would appreciate it if there is a way to customize the slide-in/slide-out speed too. The current animation is a tad bit too fast for my preference. |
Can you elaborate on what you are referring to as the "resting state"? You meant the collapsed state of the sidebar with only the website icon visible? |
I mean the line that when you hover your mouse over, it opens up and shows you the tab |
@astrologiical its the 1.9.7 release has already been updated with the 15px sensitivity fix. If you still need help with that make a new seperate issue. @dreadbalaur the container tabs has been fixed, had a typo in the code in theme-xstyle.css.
for the vertical tabs collapsed appearance, like i said above:
Before my implementation of Auto-hiding was simple, I would just shrink the width of the Sidebar to 50px (icons only) when not hovered. If you try to do that now, then the Sidebar will be forced into the built-in collapsed state (meaning you have to press the sidebar button to put it back in the expanded state. This new change creates a loop where the collapsed state continuously overtakes the expanded state, rendering the auto-hide feature as broken. This is the original issue, the topic of your post. TLDR: Firefox's scripted behavior in the 135 update, overrides the expanded vertical tabs width when using auto-hiding. I tried a difference approach as well: Making the sidebar 50px (icon-only) is impossible so.. I shrunk it to 100px instead (maximum allowed before it gets forced into the built-in collapsed state)... Then push the tabs, pinned tabs, mini toolbar to the side. Looks almost identical to the original design, doesn't look like I changed anything here, right? 2024-12-15.23-11-19.mp4But this doesn't work.
It breaks. 2024-12-15.23-22-00.mp4
So sliding them in and out of view without changing the width will have to be the solution. I spent a couple of hours last-night, even though I had work in the morning (just getting back a while ago)... trying to see what type of combinations/methods I could use to override this update. I ended up throwing away those hours of work because nothing was getting it done. If I can get it back to the old style that would be the best, but it's probably not going to happen right now. |
That makes sense, but it is a shame. Thank you for the detailed breakdown. |
Np, it really is a dissappointment. I really hope Firefox does the autohiding on their own soon, because I hate not being able to see the icons. And If anything you can use Developer Edition and still have the icons until it reaches that Nightly update. That's what I'm doing. And it shouldn't reach that update for at least another 20-30 days depending on whenever you first encountered this change. |
Update: In regards to keeping the autohidden state working with an icon-only view:
Lines 33 to 37 in 72e81ac
I don't know how viable this one will end up be, but it seems to be working with the tabs width settings. So good for now. |
I could not follow what the link to method 1 was saying, where can I find sidebarAutoHide.uc.js:19? |
Method 1 instructions!
By the end of this you should have a new icon for userChrome.js Manager, which has a |
So I actually found a great way to handle the 135 update, I just needed to dumb it down a bit and the answer was obvious.. I mentioned before, trying to shrink the vertical tabs to 100px, to avoid the scripted state-adjustment. If I apply that to the vt sidebar Lines 34 to 50 in 0688d2e
This is Nightly with 2024-12-19.09-55-24.mp4Now, Because the vertical tabs are actually 100px (when not hovered) due to the extra space (that you don't see) hidden behind the browser content, the animation looks like it stutters at the 100px mark. But it works. Let me know your thoughts on this, when you get a chance. @tthornton3-chwy @dreadbalaur |
Oooo nice one @soulhotel!! This definitely works! You're right, I do also see some stuttering with this method vs the other, but it's negligible, and this being the default solution makes sense. My back button disappears with this method, when in full-screen 😲 I made the bar red to highlight, I think it's probably solvable with z-indexes or transparencies or some sort, but worth pointing out (and currently on the clock so can't do more atm haha)! I can in theory get it to keep showing my enabling |
Fixed. I changed the navbar padding (when fullscreened) to a static number, instead of --uc-vertical-collapsed-width, while I was working through this whole 135 issue. codenew FF-ULTIMA/theme/all-global-positioning.css Lines 586 to 598 in 57ad0db
old FF-ULTIMA/theme/all-global-positioning.css Lines 586 to 598 in a227ca3
Using z-index here would mean cutting off the top of the sidebar and/or making it adjust width when the navigation bar is hovered, for simplicity I'll just stick to moving the content to the side when full screen. |
Yeah so I'll have this be the solution, Now I really need to clean up, because this issue definitely causes confusion. I'm going to make two new settings:
Edit: 2024-12-19.14-27-54.mp4 |
Working like a charm on my end! Kudos to you @soulhotel |
Hi, Sorry to necrodump this, i reinstalled 1.9.7 and wont work, What is the ultimate setting? |
Download the theme's source since these changes won't be announced or packaged until the next release (1.9.7 isn't updated with the fix). So:
|
So once you download the source, and put the files in chrome, just have |
Aside from the new |
https://github.com/soulhotel/FF-ULTIMA/blob/main/change-log.md
I could be missing something but the change Log in the source has whats different, and the main branch is up to date. |
Thanks. And are the new javascripts placed in the chrome folder? Or should they be placed outside like |
They dont need to be moved, if you aren't using autoconfig you just need the userchrome.css, usercontent.css and theme folder. I'll package everything up for you guys when I get home in a few hours. |
Hi, I just
Hi, I just downloaded it, copied the content inside my chrome folder, checked and made sure "ultima.enable.nightly.config" was enabled and basically I have to apply the same workaround as before, go to settings, disable vert tabs, re-enable vert tabs under firefox labs and it works, it wont out of the box. |
It's been packaged, at the bottom of the 1.9.7 release page as |
Hi, I just downloaded the 207 zip file, extracted all the content, copied everything inside my chrome folder, restarted firefox, Still have to disable and re enable the vertical tabs in firefox labs for the tabs to expand. Thanks for updating it tho. |
Dont get what would prompt that behavior, haven't run into it on Linux or Windows. |
Just tested the new package - behaviour is not too different from the unpackaged version I tested earlier, but I'm not sure what @jjcortes22 is |
Hey Guys, first of all, thank you so much for not letting me die here. @dreadbalaur I forgot to move the user.js to the profile folder, I did that and also checked "ultima.enable.js.config" make sure it was set to false and things seem to work now. Completely my fault, forgot to move the user.js, open, then delete it. @soulhotel Thanks for continued development. |
You can disable both and it should be as if the 135 update didn't happen. |
At the moment, |
The autohide animation no longer works after this update. The sidebar button now toggles between hiding and expanding the vertical tabs.
ultima.tabs.autohide
now toggles between the collapsed and expanded states of the tabs. Sidebar autohide animation still works.The text was updated successfully, but these errors were encountered: