Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataAddress can just be Updated using the v2 Asset Endpoint #902

Closed
efiege opened this issue Apr 20, 2024 · 3 comments
Closed

DataAddress can just be Updated using the v2 Asset Endpoint #902

efiege opened this issue Apr 20, 2024 · 3 comments
Assignees
Labels
clean-backlog requires backlog cleaning status/blocked/needs-discussion The issue requires further alignments among relevant team members task/documentation Improvements or additions to documentation

Comments

@efiege
Copy link
Contributor

efiege commented Apr 20, 2024

Documentation Update Request

Description

Assets might be updated by using the /v2 and /v3 endpoints of the management-API. However the dataAddress of the asset cannot be updated using the v3 api. This can just be done using the v2 asset endpoint.

Current Documentation

Proposed Changes

Justification

Additional Context

Deadline

Notes

@efiege efiege added the task/documentation Improvements or additions to documentation label Apr 20, 2024
@tmberthold
Copy link
Contributor

tmberthold commented Apr 20, 2024

That is not 100% correct: with the v3-api, the dataadress got embedded into the other asset-api, instead of having a seperate api for it:

image

@tmberthold tmberthold added the status/blocked/needs-discussion The issue requires further alignments among relevant team members label Apr 22, 2024
@SebastianOpriel
Copy link
Member

@efiege please correct me when I am wrong: I understood that there is a known bug that prevents updating via this endpoint.

@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
@tmberthold
Copy link
Contributor

tmberthold commented May 29, 2024

That's right, we've also just completely overhauled our postman collection, which uses the v2 APIs in exactly that place. The v3 is buggy in exactly that place, which was also recognized as a bug in the core-edc and has since been fixed. Will work after the next core-edc migration also with v3. https://github.com/sovity/edc-extensions/blob/main/docs/api/postman_collection.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-backlog requires backlog cleaning status/blocked/needs-discussion The issue requires further alignments among relevant team members task/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants