gwcs update causes crashes in build 11.0 and 11.1 pipeline

[stscijgbot-jp]

Issue JP-3840 was created on JIRA by David Law:

Testing fresh installations of build 11.0 (jwst 1.15.1) for the upcoming AAS pipeline workshop, I ran into some new pipeline crashes that were not seen back in December.  I've tracked these back to the December 19 release of gwcs 0.22.0, which is the new default to be installed with jwst 1.15.1.  Reverting gwcs to 0.21.0 solves the problem.

The issue itself manifests as a crash in the tweakreg step with an inability to convert NaN to integer, but looking at the i2d files created from image2 it's clear that there is a problem earlier on.  See gwcs_crash.png attached.

I haven't yet tested whether this causes similar crashes with more recent versions of the pipeline.  EDIT: Looks like it also affect 1.16.1, but not 1.17.1

[stscijgbot-jp]

Comment by Nadia Dencheva on JIRA:

GWCS 0.22 is fine and working with jwst 1.17. The reason for the crash is that pins on gwcs in jwst versions < 0.17 are more permissive than necessary.

There's only one reasonable "remedy" now and it is to advise users to degrade gwcs or upgrade jwst.

[stscijgbot-jp]

Comment by Nadia Dencheva on JIRA:

We could also have a jwst PyPi patch only correcting the pins on gwcs in jwst 11.x. although if a user does "pip install jwst" now they will get a working version of jwst - 1.17.1

[stscijgbot-jp]

Comment by David Law on JIRA:

Hm, I'm not sure new Pypi updates to 1.15.1 and 1.16.1 would be useful, as then users would have to know to use something other than the versions we've been advertising anyway.

Presumably we could remove the 0.22.0 gwcs release and rerelease it as 0.23.0, but that would break 1.17.0 and 1.17.1 as uninstallable (>=22 but < 23). We could update to 1.17.2, but I don't know how many other packages have gwcs as a dependency that this could cause problems for?

I'm not keen on just treating this as a documentation issue, but I don't see that there are any clearly better solutions.  I'll update JDox if you can please update the README on the jwst repo to flag this as a warning at the top of the file.

[stscijgbot-jp]

Comment by Tyler Pauly on JIRA:

I'll add the README warning - I have a PR in progress with other README updates.

[stscijgbot-jp]

Comment by Tyler Pauly on JIRA:

I'm not so worried about the widespread impact, as I'd wager that fresh installs would not be specifying 1.15.1 - 1.16.1 but would instead gather 1.17.1 by default - perhaps the largest impact is to AAS users during the workshops. Is there any value in providing AAS participants with the DMS build environment file (or instructing them to follow those installation instructions), or is the warning sufficient to reduce installation woes?

[stscijgbot-jp]

Comment by David Law on JIRA:

I think the warning will be sufficient, along with the instructors of such workshops highlighting it.  I've already contacted participants in the pipeline workshop about it, and will remind them tomorrow.