Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add specific reviewers for individual modules in jwst/ #9188

Open
zacharyburnett opened this issue Feb 13, 2025 · 0 comments · May be fixed by #9189
Open

add specific reviewers for individual modules in jwst/ #9188

zacharyburnett opened this issue Feb 13, 2025 · 0 comments · May be fixed by #9189
Assignees
Labels
automation Continuous Integration (CI) and testing automation tools infrastructure

Comments

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Feb 13, 2025

@tapastro @melanieclarke it might be advantageous to add specific names to .github/CODEOWNERS for specific modules, so that people are automatically tagged for review by default if a module has a PR and no reviewer is set:

jwst/.github/CODEOWNERS

Lines 6 to 11 in 7a69919

# developers can own some specific paths
/.github/ @spacetelescope/jwst-pipeline-developers # CI files
/* @spacetelescope/jwst-pipeline-developers # top level files only
/changes/** @spacetelescope/jwst-pipeline-developers # changelogs
/docs/** @spacetelescope/jwst-pipeline-developers # docs
/jwst/regtest/** @spacetelescope/jwst-pipeline-developers # regtest code

For instance, according to https://github.com/spacetelescope/jwst/wiki/Maintainers#step-and-subpackage-maintainers we could add

/jwst/combine_1d @stscirij @tapastro 

This would replace the page in the Wiki, and I feel it would be easier to keep maintained as it's in the repository itself and someone who was pinged who is no longer the lead can immediately suggest a successor.

@zacharyburnett zacharyburnett self-assigned this Feb 13, 2025
@zacharyburnett zacharyburnett added infrastructure automation Continuous Integration (CI) and testing automation tools labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant