-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for "Callback Streams" and "Blocking Read/Write Streams" is unclear. #571
Comments
Thanks for bringing this up! There is hardly any documentation for "blocking" streams: https://python-sounddevice.readthedocs.io/en/0.5.1/usage.html#blocking-read-write-streams If somebody has used them, I'd be interested in hearing about it.
Yeah, I consider the examples an important part of the documentation. But I'm open for improvements in the prose part of the documentation as well!
Yeah, this could definitely be improved. For example, I think it is not explicitly mentioned that the callback function runs in an OS-thread created by the PortAudio library.
This is described in excruciating detail, did you not find it? The description can for sure be improved, though.
Yes please, that would be great! |
Thanks for your politeness!
I personally haven't used them (and honestly I don't quite understand how they work), but I am willing to help, both on the docs side and the implementation side!
I also consider them to be very important, but i think they should be accessed as a supplement, don't you think? I would like to hear your opinion on this.
From what i saw, it is not. Although it is mentioned in at least one of the examples.
Yes, sorry I just didn't explain myself correctly :P
In order to contribute, should I just submit a PR referencing this issue and refining it if it is not clear enough / has incorrect info? Are you willing to accept PRs on this issue? |
Yes, definitely! |
By reading the docs it is unclear to me how Callback functions work, when they are called and all the parameters do exactly . I think I have figured it out from the examples and the source code, but i think this project has a lot of lost potential just because these more "advanced" features don't have much documentation. I would be willing to help write some of the documentation if necessary, although i first want to make sure I understand these features correctly.
The text was updated successfully, but these errors were encountered: