From d130a23eeebb0f2c41a2956ed1179501ccc1bd1d Mon Sep 17 00:00:00 2001 From: byzz Date: Sat, 9 Dec 2023 23:54:19 +0900 Subject: [PATCH] Add php 8.3 matrix (#460) * Add php 8.3 matrix * fix: Invalid test code. * Revert "fix: Invalid test code." This reverts commit f1a45e2f68676c213ed40c720ab10ca7f48a2163. * fix: Invalid test code. * fix: Invalid test code. --------- Co-authored-by: byzz --- .github/workflows/run-tests.yml | 2 +- phpunit.xml.dist | 3 +++ tests/IntegrationTest.php | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index a7588aa..755ab88 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: true matrix: - php: [8.2, 8.1, 8.0] + php: [8.3, 8.2, 8.1, 8.0] laravel: [10.*, 9.*, 8.*] dependency-version: [prefer-lowest, prefer-stable] include: diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 3bbe22a..bf61db7 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -36,4 +36,7 @@ + + + diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php index f47bc0b..f519f1c 100644 --- a/tests/IntegrationTest.php +++ b/tests/IntegrationTest.php @@ -211,7 +211,7 @@ $this->assertFalse($firstResponse->headers->has('X-Cached-At')); assertTrue($secondResponse->headers->has('X-Cached-At')); - $this->assertInstanceOf(DateTime::class, $secondResponse->headers->getDate('X-Cached-At')); + $this->assertInstanceOf(DateTimeInterface::class, $secondResponse->headers->getDate('X-Cached-At')); assertSameResponse($firstResponse, $secondResponse); });