Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings for examples #4789

Open
mattgarrish opened this issue Sep 7, 2024 · 0 comments
Open

Headings for examples #4789

mattgarrish opened this issue Sep 7, 2024 · 0 comments

Comments

@mattgarrish
Copy link

Is your feature request related to a problem? Please describe.
We've had a request to change the examples so they have proper headings so screen reader users can navigate to them more easily.

Describe the solution you'd like
Instead of using a div with class marker on the example headings, add role=heading + aria-level like is done for note headings.

Describe any alternatives you've considered
I'm considering a post-processing step to find all the divs and convert them to headings, but if this is generally useful it seems like it would be helpful if it were built into all specs.

I can't find anything in the issues about why examples are treated differently from notes, so if there's a problem that makes this untenable I'd love to hear about it before I go and hack at the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant