From c03f4b6450c73345dc890e01d891d9993540ac46 Mon Sep 17 00:00:00 2001 From: Matt Welke Date: Fri, 21 Jun 2024 16:27:13 -0400 Subject: [PATCH] Removed unused properties from chart defaults. When webhook patching is disabled, the other properties are unused. For example, `{{- with .Values.admissionWebhooks.patch.tolerations }}` is nested within `{{- if and .Values.admissionWebhooks.enabled .Values.admissionWebhooks.patch.enabled (not .Values.admissionWebhooks.certManager.enabled) }}`. --- packs/oam-app-controller-0.0.4/values.yaml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packs/oam-app-controller-0.0.4/values.yaml b/packs/oam-app-controller-0.0.4/values.yaml index 75347aaf..dbfb64c9 100644 --- a/packs/oam-app-controller-0.0.4/values.yaml +++ b/packs/oam-app-controller-0.0.4/values.yaml @@ -164,18 +164,11 @@ charts: certificate: mountPath: /etc/k8s-webhook-certs patch: - enabled: true - image: - repository: cgr.dev/chainguard/kube-webhook-certgen - tag: latest - pullPolicy: IfNotPresent - nodeSelector: {} - affinity: {} - tolerations: [] + enabled: false appConversion: enabled: false certManager: - enabled: false + enabled: true revisionHistoryLimit: 3 ## @param kubeClient.qps The qps for reconcile clients