Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Means of only saving set settings #1892

Open
1 task done
mgabeler-lee-6rs opened this issue Jul 29, 2024 · 1 comment
Open
1 task done

Means of only saving set settings #1892

mgabeler-lee-6rs opened this issue Jul 29, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@mgabeler-lee-6rs
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Currently WriteConfig() and its variants save all settings, including making any default values explicit.

Proposed Solution

  • Expose a ChangedSettings() method similar to AllSettings(), but which only returns values that pass IsSet()
  • Expose variations on WriteSettings() that use ChangedSettings() in place of AllSettings()

Alternatives Considered

Re-implementing the core of viper's WriteSettings by hand is possible, but it requires either losing some features or re-implementing many by hand, since the config encoding structures are not exported, nor is the deep key mapping (deepSearch()) used for nested settings.

Additional Information

No response

@mgabeler-lee-6rs mgabeler-lee-6rs added the kind/enhancement New feature or request label Jul 29, 2024
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant