Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body clips with default page width before 875px breakpoint #54

Closed
numberoverzero opened this issue Sep 11, 2015 · 2 comments
Closed

Body clips with default page width before 875px breakpoint #54

numberoverzero opened this issue Sep 11, 2015 · 2 comments
Labels

Comments

@numberoverzero
Copy link
Contributor

While working on #44 I discovered that document text gets clipped under ~911 px but the nav doesn't move until 875px.

I uploaded three images to show off the problem with the current breakpoints and the default theme width.

Where are the 875/870px numbers from for the media queries?

@bitprophet
Copy link
Collaborator

Thanks for the report! Confirming that I can recreate this on my end, huh. It goes by real fast if you resize as fast as I normally do when spot checking the smaller width layouts, which is one reason why it's gone uncaught so far.

As with everything else in here, those specific numbers come from the precursor themes we're based on, so I dunno exactly how they were calculated. I just checked and e.g. http://python-requests.org (which as far as I can tell is still using Kenneth's original theme) has the same bug. So it's probably been around for some time & may not be due to any changes we've made on our end.

Open to suggestions for a fix, don't have time to dig right now for something this low priority :)

@bitprophet bitprophet added the bug label Sep 13, 2015
spookylukey added a commit to spookylukey/alabaster that referenced this issue Jul 22, 2020
Also now respects theme_page_width for layout switching.
@AA-Turner
Copy link
Member

Closed by #174.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants