Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use makefile instead of calling build-sphinx ? #20

Open
peircej opened this issue Nov 24, 2022 · 1 comment
Open

Use makefile instead of calling build-sphinx ? #20

peircej opened this issue Nov 24, 2022 · 1 comment

Comments

@peircej
Copy link

peircej commented Nov 24, 2022

Users may have customised their makefile to include additional steps while building the html, but these are then lost when using because instead of calling
make html
it calls
sphinx-build -b html "$doc_dir" "$tmp_dir" $INPUT_SPHINX_OPTIONS

Is there any reason not to call like this?
make html BUILDDIR="$tmp_dir" SPHINXOPTS="$INPUT_SPHINX_OPTIONS"
which would, I think, achieve the same.

The only change later in main.sh would be

rm -rf $tmp_dir/.doctrees
cp -vr $tmp_dir/. $INPUT_TARGET_PATH

becomes

rm -rf $tmp_dir/html/.doctrees
cp -vr $tmp_dir/html/. $INPUT_TARGET_PATH

because make by default will add /html for that build

@SilverRainZ
Copy link
Member

Sure, I will add this in v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants