Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPIRE Controller Manager configuration Section #532

Closed
maia-iyer opened this issue Oct 10, 2024 · 0 comments · Fixed by #537
Closed

Add SPIRE Controller Manager configuration Section #532

maia-iyer opened this issue Oct 10, 2024 · 0 comments · Fixed by #537
Assignees
Labels
backend Tornjak API (Backend) go Pull requests that update Go code
Milestone

Comments

@maia-iyer
Copy link
Collaborator

maia-iyer commented Oct 10, 2024

Part of #529

It makes sense that CRD APIs are only enabled when Tornjak is configured to do so (or when the SPIRE Controller manager is definitely deployed).

For now, we will trigger this behavior through an additional plugin configuration section in Tornjak:

plugins {
  ...

  # [optional] if this section is included, CRD APIs will work
  # /api/v1/spire/federations APIs will log warnings
  # if this section is excluded, CRD APIs will return errors
  # /api/v1/spire/federations APIs will work
  SPIRECRDManager {
    # [required] Tornjak will create CRDs with this label for the controller-manager to pick up
    class_name = "spire-mgmt-spire"
  }
  ...
}
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Oct 10, 2024
@maia-iyer maia-iyer added this to the 2.0.0 milestone Oct 10, 2024
@maia-iyer maia-iyer self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant