Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor helpers #574

Open
maia-iyer opened this issue Jan 21, 2025 · 0 comments
Open

Refactor helpers #574

maia-iyer opened this issue Jan 21, 2025 · 0 comments
Labels
backend Tornjak API (Backend) go Pull requests that update Go code

Comments

@maia-iyer
Copy link
Collaborator

maia-iyer commented Jan 21, 2025 •
edited
Loading

Currently many of the functions in this helpers file are taken directly from the spire-controller-manager repo so that we can easily translate from CRD type to SPIRE API type to unstructure types for interacting with k8s api, and back as well. It would be ideal if we could import and call these functions directly - otherwise changes in the type in upstream repos can break our implementation in this repo.

General refactoring may also be useful.
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Tornjak API (Backend) go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maia-iyer