Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AOT compiled components #15

Closed
radu-matei opened this issue Feb 19, 2024 · 3 comments
Closed

Support AOT compiled components #15

radu-matei opened this issue Feb 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@radu-matei
Copy link
Member

ref spinframework/spin#2284
ref containerd/runwasi#405

This issue tracks support for AOT compiled components in the shim.
runwasi will support compiling the Wasm components, which will allow skipping JIT compilation every time the shim starts a new application.

@radu-matei radu-matei added the enhancement New feature or request label Feb 19, 2024
@lann
Copy link

lann commented Feb 19, 2024

Spin will need some way for the runtime to explicitly opt-in to this and some way to pass the precompiled file (which could be the same thing as long as the latter isn't from untrusted input).

@radu-matei
Copy link
Member Author

I was imagining a new OCI loader method with an explicit cwasm directory — so even if the directory was there, an implementation could choose to ignore it.

Re: untrusted input, it is the Spin shim that would compile and store the result in containerd's content store. So the content is ~as trusted as uncompiled Wasm the shim compiles today.

@jsturtevant
Copy link
Contributor

fixed by #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants