From 30019639870d9bbffeb083c94db369c592c5a67b Mon Sep 17 00:00:00 2001 From: Joe Stein <569991+jas14@users.noreply.github.com> Date: Tue, 25 Feb 2025 16:27:27 -0800 Subject: [PATCH] Add Rails 7.2 support (#279) Adds Rails 7.2 to the Appraisals and CI matrix. --- .github/workflows/super_diff.yml | 1 + Appraisals | 9 ++++++- CHANGELOG.md | 1 + gemfiles/rails_7_2_rspec_gte_3_10.gemfile | 30 +++++++++++++++++++++++ gemfiles/rails_7_2_rspec_gte_3_13.gemfile | 30 +++++++++++++++++++++++ gemfiles/rails_7_2_rspec_lt_3_10.gemfile | 26 ++++++++++++++++++++ 6 files changed, 96 insertions(+), 1 deletion(-) create mode 100644 gemfiles/rails_7_2_rspec_gte_3_10.gemfile create mode 100644 gemfiles/rails_7_2_rspec_gte_3_13.gemfile create mode 100644 gemfiles/rails_7_2_rspec_lt_3_10.gemfile diff --git a/.github/workflows/super_diff.yml b/.github/workflows/super_diff.yml index f937d217..230691d1 100644 --- a/.github/workflows/super_diff.yml +++ b/.github/workflows/super_diff.yml @@ -61,6 +61,7 @@ jobs: - rails_6_1 - rails_7_0 - rails_7_1 + - rails_7_2 - no_rails rspec_appraisal: - rspec_lt_3_10 diff --git a/Appraisals b/Appraisals index 180dd2b4..227b12d4 100644 --- a/Appraisals +++ b/Appraisals @@ -30,6 +30,13 @@ appraisals = { gem 'rails', '~> 7.1.0' gem 'sqlite3', '~> 1.4.0', platform: %i[ruby mswin mingw] end, + rails_7_2: + proc do + instance_eval(&rails_dependencies) + + gem 'rails', '~> 7.2.0' + gem 'sqlite3', '~> 1.4.0', platform: %i[ruby mswin mingw] + end, no_rails: proc {}, rspec_lt_3_10: proc do |with_rails| @@ -66,7 +73,7 @@ appraisals = { end } -rails_appraisals = %i[no_rails rails_6_1 rails_7_0 rails_7_1] +rails_appraisals = %i[no_rails rails_6_1 rails_7_0 rails_7_1 rails_7_2] rspec_appraisals = %i[rspec_lt_3_10 rspec_gte_3_10 rspec_gte_3_13] rails_appraisals.each do |rails_appraisal| diff --git a/CHANGELOG.md b/CHANGELOG.md index aa4f84d8..53c28b57 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ ### Features - Add official Rails 7.1 support. [#278](https://github.com/splitwise/super_diff/pull/278) +- Add official Rails 7.2 support. [#279](https://github.com/splitwise/super_diff/pull/279) ### Other changes diff --git a/gemfiles/rails_7_2_rspec_gte_3_10.gemfile b/gemfiles/rails_7_2_rspec_gte_3_10.gemfile new file mode 100644 index 00000000..65812f9e --- /dev/null +++ b/gemfiles/rails_7_2_rspec_gte_3_10.gemfile @@ -0,0 +1,30 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "appraisal", git: "https://github.com/thoughtbot/appraisal" +gem "bundler-audit" +gem "childprocess" +gem "climate_control" +gem "prettier_print" +gem "pry-byebug", platform: :mri +gem "pry-nav", platform: :jruby +gem "rake" +gem "rubocop" +gem "syntax_tree" +gem "syntax_tree-haml" +gem "syntax_tree-rbs" +gem "activerecord-jdbcsqlite3-adapter", platform: :jruby +gem "jdbc-sqlite3", platform: :jruby +gem "net-ftp" +gem "combustion" +gem "rails", "~> 7.2.0" +gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw] +gem "rspec", "3.12.0" +gem "rspec-core", "3.12.0" +gem "rspec-expectations", "3.12.3" +gem "rspec-mocks", "3.12.0" +gem "rspec-support", "3.12.0" +gem "rspec-rails" + +gemspec path: "../" diff --git a/gemfiles/rails_7_2_rspec_gte_3_13.gemfile b/gemfiles/rails_7_2_rspec_gte_3_13.gemfile new file mode 100644 index 00000000..e5ee6711 --- /dev/null +++ b/gemfiles/rails_7_2_rspec_gte_3_13.gemfile @@ -0,0 +1,30 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "appraisal", git: "https://github.com/thoughtbot/appraisal" +gem "bundler-audit" +gem "childprocess" +gem "climate_control" +gem "prettier_print" +gem "pry-byebug", platform: :mri +gem "pry-nav", platform: :jruby +gem "rake" +gem "rubocop" +gem "syntax_tree" +gem "syntax_tree-haml" +gem "syntax_tree-rbs" +gem "activerecord-jdbcsqlite3-adapter", platform: :jruby +gem "jdbc-sqlite3", platform: :jruby +gem "net-ftp" +gem "combustion" +gem "rails", "~> 7.2.0" +gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw] +gem "rspec", "3.13.0" +gem "rspec-core", "3.13.0" +gem "rspec-expectations", "3.13.0" +gem "rspec-mocks", "3.13.0" +gem "rspec-support", "3.13.0" +gem "rspec-rails" + +gemspec path: "../" diff --git a/gemfiles/rails_7_2_rspec_lt_3_10.gemfile b/gemfiles/rails_7_2_rspec_lt_3_10.gemfile new file mode 100644 index 00000000..c4aaa6b5 --- /dev/null +++ b/gemfiles/rails_7_2_rspec_lt_3_10.gemfile @@ -0,0 +1,26 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "appraisal", git: "https://github.com/thoughtbot/appraisal" +gem "bundler-audit" +gem "childprocess" +gem "climate_control" +gem "prettier_print" +gem "pry-byebug", platform: :mri +gem "pry-nav", platform: :jruby +gem "rake" +gem "rubocop" +gem "syntax_tree" +gem "syntax_tree-haml" +gem "syntax_tree-rbs" +gem "activerecord-jdbcsqlite3-adapter", platform: :jruby +gem "jdbc-sqlite3", platform: :jruby +gem "net-ftp" +gem "combustion" +gem "rails", "~> 7.2.0" +gem "sqlite3", "~> 1.4.0", platform: [:ruby, :mswin, :mingw] +gem "rspec", "~> 3.9.0" +gem "rspec-rails" + +gemspec path: "../"