diff --git a/helios-client/src/main/java/com/spotify/helios/client/EndpointIterator.java b/helios-client/src/main/java/com/spotify/helios/client/EndpointIterator.java index 15a731f2a..9822e1cdd 100644 --- a/helios-client/src/main/java/com/spotify/helios/client/EndpointIterator.java +++ b/helios-client/src/main/java/com/spotify/helios/client/EndpointIterator.java @@ -22,14 +22,11 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.base.Predicate; import com.google.common.collect.ImmutableList; -import com.google.common.collect.Iterables; import java.util.Iterator; import java.util.List; import java.util.NoSuchElementException; import java.util.Random; -import javax.annotation.Nullable; /** * An {@link Iterator} of {@link Endpoint} that restarts when it reaches the end. @@ -74,18 +71,4 @@ public Endpoint next() { public void remove() { throw new UnsupportedOperationException(); } - - /** - * @return true if any endpoints' scheme is HTTPS. - */ - boolean hasHttps() { - return Iterables.any(endpoints, new Predicate() { - @Override - public boolean apply(@Nullable Endpoint endpoint) { - return endpoint != null && endpoint.getUri() != null - && endpoint.getUri().getScheme() != null - && endpoint.getUri().getScheme().equalsIgnoreCase("https"); - } - }); - } } diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/Deployment.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/Deployment.java index 2aea6bdfa..03562350c 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/Deployment.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/Deployment.java @@ -55,7 +55,7 @@ public class Deployment extends Descriptor { private final String deploymentGroupName; /** - * Constructor + * Constructor. * * @param jobId The id of the job. * @param goal The desired state (i.e. goal) of the task/deployment. diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/DockerVersion.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/DockerVersion.java index ffacb5d37..32bdaf36c 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/DockerVersion.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/DockerVersion.java @@ -52,6 +52,8 @@ public class DockerVersion { private final String version; /** + * Constructor. + * * @param apiVersion The Docker api version supported. * @param arch The architecture of the machine. * @param gitCommit The git commit from which Docker was built. diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/HostInfo.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/HostInfo.java index 983ec34d2..4976f7ad9 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/HostInfo.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/HostInfo.java @@ -73,6 +73,8 @@ public class HostInfo extends Descriptor { private final String dockerCertPath; /** + * Constructor. + * * @param hostname The hostname of the agent. * @param uname The output of the uname command. * @param architecture The architecture of the Agent. diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobId.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobId.java index 57215cac8..e32589b51 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobId.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobId.java @@ -99,7 +99,7 @@ private JobId(final String id) { } /** - * Private constructor for use by {@link #parse(String)} + * Private constructor for use by {@link #parse(String)}. * * @param name The name of the job. */ diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobStatus.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobStatus.java index 5590b1f31..ec88c3df8 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobStatus.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/JobStatus.java @@ -81,14 +81,14 @@ public Job getJob() { } /** - * @return a map of host to task status. + * Return a map of host to task status. */ public Map getTaskStatuses() { return taskStatuses; } /** - * @return a map of host to deployment. + * Return a map of host to deployment. */ public Map getDeployments() { return deployments; diff --git a/helios-client/src/main/java/com/spotify/helios/common/descriptors/TaskStatus.java b/helios-client/src/main/java/com/spotify/helios/common/descriptors/TaskStatus.java index 3bf390f55..bd0abf951 100644 --- a/helios-client/src/main/java/com/spotify/helios/common/descriptors/TaskStatus.java +++ b/helios-client/src/main/java/com/spotify/helios/common/descriptors/TaskStatus.java @@ -88,6 +88,8 @@ public enum State { private final String containerError; /** + * Constructor. + * * @param job The job the task is running. * @param goal The desired state of the task. * @param state The state of the task. diff --git a/helios-client/src/test/java/com/spotify/helios/common/descriptors/RolloutOptionsTest.java b/helios-client/src/test/java/com/spotify/helios/common/descriptors/RolloutOptionsTest.java index 90adda539..4a9d32ca1 100644 --- a/helios-client/src/test/java/com/spotify/helios/common/descriptors/RolloutOptionsTest.java +++ b/helios-client/src/test/java/com/spotify/helios/common/descriptors/RolloutOptionsTest.java @@ -37,9 +37,6 @@ package com.spotify.helios.common.descriptors; -import static com.spotify.helios.common.descriptors.RolloutOptions.DEFAULT_IGNORE_FAILURES; -import static com.spotify.helios.common.descriptors.RolloutOptions.DEFAULT_MIGRATE; -import static com.spotify.helios.common.descriptors.RolloutOptions.DEFAULT_TOKEN; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.nullValue; import static org.hamcrest.core.Is.is; diff --git a/helios-services/pom.xml b/helios-services/pom.xml index 0b770026b..010027720 100644 --- a/helios-services/pom.xml +++ b/helios-services/pom.xml @@ -417,7 +417,7 @@ maven-assembly-plugin - 2.5.3 + 3.1.0 ${project.basedir}/src/assembly/helios-solo.xml diff --git a/helios-services/src/main/java/com/spotify/helios/agent/Supervisor.java b/helios-services/src/main/java/com/spotify/helios/agent/Supervisor.java index 327aafd1d..dc3938540 100644 --- a/helios-services/src/main/java/com/spotify/helios/agent/Supervisor.java +++ b/helios-services/src/main/java/com/spotify/helios/agent/Supervisor.java @@ -168,7 +168,7 @@ public boolean isDone() { } /** - * Get the current container id + * Get the current container id. * * @return The container id. */ diff --git a/helios-services/src/main/java/com/spotify/helios/master/JobDoesNotExistException.java b/helios-services/src/main/java/com/spotify/helios/master/JobDoesNotExistException.java index 70b6f51ee..6e5080ca0 100644 --- a/helios-services/src/main/java/com/spotify/helios/master/JobDoesNotExistException.java +++ b/helios-services/src/main/java/com/spotify/helios/master/JobDoesNotExistException.java @@ -20,7 +20,6 @@ package com.spotify.helios.master; - import static java.lang.String.format; import com.spotify.helios.common.HeliosException; diff --git a/helios-services/src/main/java/com/spotify/helios/master/MasterService.java b/helios-services/src/main/java/com/spotify/helios/master/MasterService.java index 7827f2eb2..9aa1a3fcc 100644 --- a/helios-services/src/main/java/com/spotify/helios/master/MasterService.java +++ b/helios-services/src/main/java/com/spotify/helios/master/MasterService.java @@ -38,7 +38,6 @@ import com.google.common.io.Resources; import com.google.common.util.concurrent.AbstractIdleService; import com.spotify.helios.common.HeliosRuntimeException; -import com.spotify.helios.common.descriptors.TaskStatusEvent; import com.spotify.helios.master.http.VersionResponseFilter; import com.spotify.helios.master.metrics.HealthCheckGauge; import com.spotify.helios.master.metrics.ReportingResourceMethodDispatchAdapter; diff --git a/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java b/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java index cbf61c4da..b9238c8bc 100644 --- a/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java +++ b/helios-services/src/main/java/com/spotify/helios/master/ZooKeeperMasterModel.java @@ -50,7 +50,6 @@ import com.google.common.base.MoreObjects; import com.google.common.base.Preconditions; import com.google.common.base.Strings; -import com.google.common.base.Throwables; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; diff --git a/helios-services/src/main/java/com/spotify/helios/servicescommon/ZooKeeperRegistrar.java b/helios-services/src/main/java/com/spotify/helios/servicescommon/ZooKeeperRegistrar.java index 8022a36ae..86637e2e2 100644 --- a/helios-services/src/main/java/com/spotify/helios/servicescommon/ZooKeeperRegistrar.java +++ b/helios-services/src/main/java/com/spotify/helios/servicescommon/ZooKeeperRegistrar.java @@ -27,14 +27,14 @@ public interface ZooKeeperRegistrar { /** - * Called upon startup + * Called upon startup. * * @throws Exception If an unexpected error occurs. */ void startUp() throws Exception; /** - * Called upon shutdown + * Called upon shutdown. * * @throws Exception If an unexpected error occurs. */ diff --git a/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUndeployPlannerTest.java b/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUndeployPlannerTest.java index c95cc5410..6f8410dbd 100644 --- a/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUndeployPlannerTest.java +++ b/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUndeployPlannerTest.java @@ -20,7 +20,6 @@ package com.spotify.helios.rollingupdate; - import static org.junit.Assert.assertEquals; import com.google.common.collect.ImmutableList; diff --git a/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUpdatePlannerTest.java b/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUpdatePlannerTest.java index d269744b4..810427011 100644 --- a/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUpdatePlannerTest.java +++ b/helios-services/src/test/java/com/spotify/helios/rollingupdate/RollingUpdatePlannerTest.java @@ -20,7 +20,6 @@ package com.spotify.helios.rollingupdate; - import static org.junit.Assert.assertEquals; import com.google.common.collect.ImmutableList; diff --git a/helios-system-tests/src/main/java/com/spotify/helios/system/DnsServerTest.java b/helios-system-tests/src/main/java/com/spotify/helios/system/DnsServerTest.java index 357aa462c..cd25127e3 100644 --- a/helios-system-tests/src/main/java/com/spotify/helios/system/DnsServerTest.java +++ b/helios-system-tests/src/main/java/com/spotify/helios/system/DnsServerTest.java @@ -20,7 +20,6 @@ package com.spotify.helios.system; - import static com.spotify.docker.client.DockerClient.LogsParam.stderr; import static com.spotify.docker.client.DockerClient.LogsParam.stdout; import static com.spotify.helios.common.descriptors.HostStatus.Status.UP; diff --git a/helios-system-tests/src/main/java/com/spotify/helios/system/LabelTest.java b/helios-system-tests/src/main/java/com/spotify/helios/system/LabelTest.java index ae72c30a5..4afa2258d 100644 --- a/helios-system-tests/src/main/java/com/spotify/helios/system/LabelTest.java +++ b/helios-system-tests/src/main/java/com/spotify/helios/system/LabelTest.java @@ -42,6 +42,8 @@ public class LabelTest extends SystemTestBase { /** + * Get labels for a set of hosts. + * * @param hosts Hostnames for which to get labels. * * @return a map whose keys are hostnames and values are maps of label key-vals. diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosConfig.java b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosConfig.java index 54b10170a..a306d8642 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosConfig.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosConfig.java @@ -35,7 +35,7 @@ public class HeliosConfig { public static final String APP_CONFIG_FILE = "helios.conf"; /** - * @return The root configuration loaded from the helios configuration files. + * Return the root configuration loaded from the helios configuration files. */ static Config loadConfig() { final ConfigResolveOptions resolveOptions = ConfigResolveOptions @@ -52,11 +52,11 @@ static Config loadConfig() { } /** + * Return the name of the default profile. + * * @param profilePath The path at which the default profile is specified. * @param profilesPath The path at which profiles are nested. * @param rootConfig The config file root to read the default profile from. - * - * @return The name of the default profile. */ static Config getDefaultProfile( final String profilePath, final String profilesPath, final Config rootConfig) { @@ -69,11 +69,11 @@ static Config getDefaultProfile( } /** + * Return the requested configuration, or an empty configuration if profile is null. + * * @param profilesPath The path at which profiles are nested. * @param profile The name of the profile to load. * @param rootConfig The config file root to load profiles from. - * - * @return The requested configuration, or an empty configuration if profile is null. */ static Config getProfile( final String profilesPath, final String profile, final Config rootConfig) { diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeployment.java b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeployment.java index 8e2ca539d..98a677908 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeployment.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeployment.java @@ -28,13 +28,18 @@ * run. */ public interface HeliosDeployment extends AutoCloseable { + /** - * @return A helios client connected to the master(s) of this helios deployment. + * A helios client connected to the master(s) of this helios deployment. + * + * @return {@link HeliosClient} */ HeliosClient client(); /** - * Returns the host and port information that the deployment is available at. + * Returns the host and port information that the deployment is available at. + * + * @return {@link HostAndPort} */ // TODO (mbrown): should this be URI to capture scheme info also? HostAndPort address(); diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeploymentResource.java b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeploymentResource.java index 6a62688ad..174c8711b 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeploymentResource.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosDeploymentResource.java @@ -49,6 +49,8 @@ public class HeliosDeploymentResource extends ExternalResource { private final HeliosDeployment deployment; /** + * Constructor. + * * @param deployment The Helios deployment to expose to your JUnit tests. */ public HeliosDeploymentResource(final HeliosDeployment deployment) { @@ -142,8 +144,10 @@ public void after() { } /** - * @return a Helios client connected to the Helios deployment supplied when instantiating the - * HeliosDeploymentResource. + * Return a Helios client connected to the Helios deployment supplied when instantiating the + * HeliosDeploymentResource. + * + * @return {@link HeliosClient} */ public HeliosClient client() { return deployment.client(); diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosSoloDeployment.java b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosSoloDeployment.java index 12766ac36..c3945e9a1 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/HeliosSoloDeployment.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/HeliosSoloDeployment.java @@ -375,11 +375,11 @@ private List probeCommand(final String probeName) { } /** + * Return the container ID of the Helios Solo container. + * * @param heliosHost The address at which the Helios agent should expect to find the Helios * master. * - * @return The container ID of the Helios Solo container. - * * @throws HeliosDeploymentException if Helios Solo could not be deployed. */ private String deploySolo(final String heliosHost) throws HeliosDeploymentException { @@ -483,14 +483,16 @@ private String randomString() { } /** - * @return A helios client connected to the master of this HeliosSoloDeployment. + * Return a helios client connected to the master of this HeliosSoloDeployment. */ public HeliosClient client() { return this.heliosClient; } /** - * @return The container ID of the Helios Solo container. + * Return the container ID of the Helios Solo container. + * + * @return container ID as a String */ public String heliosContainerId() { return heliosContainerId; @@ -599,36 +601,42 @@ public T apply(final Exception ex) { } /** - * @return A Builder that can be used to instantiate a HeliosSoloDeployment. + * Return a Builder that can be used to instantiate a HeliosSoloDeployment. + * + * @return {@link Builder} */ public static Builder builder() { return builder(null); } /** - * @param profile A configuration profile used to populate builder options. + * Return a Builder that can be used to instantiate a HeliosSoloDeployment. * - * @return A Builder that can be used to instantiate a HeliosSoloDeployment. + * @param profile A configuration profile used to populate builder options. + * @return {@link Builder} */ public static Builder builder(final String profile) { return new Builder(profile, HeliosConfig.loadConfig()); } /** - * @return a Builder with its Docker Client configured automatically using the - * DOCKER_HOST and DOCKER_CERT_PATH environment variables, or - * sensible defaults if they are absent. + * Return a Builder with its Docker Client configured automatically using the + * DOCKER_HOST and DOCKER_CERT_PATH environment variables, or + * sensible defaults if they are absent. + * + * @return {@link Builder} */ public static Builder fromEnv() { return fromEnv(null); } /** - * @param profile A configuration profile used to populate builder options. + * Return a Builder with its Docker Client configured automatically using the + * DOCKER_HOST and DOCKER_CERT_PATH environment variables, or + * sensible defaults if they are absent. * - * @return a Builder with its Docker Client configured automatically using the - * DOCKER_HOST and DOCKER_CERT_PATH environment variables, or - * sensible defaults if they are absent. + * @param profile A configuration profile used to populate builder options. + * @return {@link Builder} */ public static Builder fromEnv(final String profile) { try { @@ -713,6 +721,8 @@ private void configureGoogleContainerRegistry(Config subConfig) { /** * By default, the {@link #heliosSoloImage} will be checked for updates before creating a * container by doing a "docker pull". Call this method with "false" to disable this behavior. + * + * @return {@link Builder} */ public Builder checkForNewImages(boolean enabled) { this.pullBeforeCreate = enabled; @@ -724,6 +734,8 @@ public Builder checkForNewImages(boolean enabled) { * {@link HeliosSoloDeployment#close()} is called. Call this method with "false" to disable this * (which is probably only useful for developing helios-solo or this class itself and * inspecting logs). + * + * @return {@link Builder} */ public Builder removeHeliosSoloOnExit(boolean enabled) { this.removeHeliosSoloContainerOnExit = enabled; @@ -734,6 +746,8 @@ public Builder removeHeliosSoloOnExit(boolean enabled) { * Set the number of seconds Helios solo will wait for jobs to be undeployed and, as a result, * their associated Docker containers to stop running before shutting itself down. * The default is 30 seconds. + * + * @return {@link Builder} */ public Builder jobUndeployWaitSeconds(int seconds) { this.jobUndeployWaitSeconds = seconds; @@ -799,6 +813,8 @@ public Builder heliosClient(final HeliosClient heliosClient) { /** * Customize the image used for helios-solo. If not set defaults to * "spotify/helios-solo:latest". + * + * @return {@link Builder} */ public Builder heliosSoloImage(String image) { this.heliosSoloImage = Preconditions.checkNotNull(image); @@ -863,6 +879,8 @@ public Builder env(final String key, final Object value) { * Override the credentials used for Google Container Registry. If not set, then the builder * will default to checking to see if an entry for "googleContainerRegistryCredentials" exists * in the configuration profile. + * + * @return {@link Builder} */ public Builder googleContainerRegistryCredentials(File credentials) { this.googleContainerRegistryCredentials = Optional.of(credentials); diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobBuilder.java b/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobBuilder.java index 3c1e3ae73..04a1f8ff5 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobBuilder.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobBuilder.java @@ -320,6 +320,8 @@ public TemporaryJob deploy(final List hosts) { * Set the {@link #image(String)} field for the Docker image to use in this job from the output of * docker-maven-plugin (image_info.json on classpath) or dockerfile-maven-plugin * (docker/image-name on classpath) + * + * @return {@link TemporaryJobBuilder} */ public TemporaryJobBuilder imageFromBuild() { final String envPath = env.get("IMAGE_INFO_PATH"); diff --git a/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobs.java b/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobs.java index b843dc612..930705ddb 100644 --- a/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobs.java +++ b/helios-testing/src/main/java/com/spotify/helios/testing/TemporaryJobs.java @@ -308,7 +308,7 @@ private static List getListByKey(final String key, final Config config) *
  • HELIOS_ENDPOINTS - If set, use one of the endpoints, which are specified as a comma * separated list.
    • *
  • Testing Profile - If a testing profile can be loaded, use either {@code domain} or - * endpoints if present. If both are specified, {@code domain} takes precedence.
    • + * {@code endpoints} if present. If both are specified, {@code domain} takes precedence. *
  • DOCKER_HOST - If set, assume a helios master is running on this host, so connect to it on * port {@code 5801}.
    • *
  • Use {@code http://localhost:5801}
    • diff --git a/helios-tools/src/main/java/com/spotify/helios/cli/Target.java b/helios-tools/src/main/java/com/spotify/helios/cli/Target.java index 8d79f8d8f..59a186b46 100644 --- a/helios-tools/src/main/java/com/spotify/helios/cli/Target.java +++ b/helios-tools/src/main/java/com/spotify/helios/cli/Target.java @@ -146,7 +146,7 @@ public int hashCode() { } /** - * Create a target from an explicit endpoint + * Create a target from an explicit endpoint. * * @param endpoint The endpoint. * @@ -157,7 +157,7 @@ public static Target from(final URI endpoint) { } /** - * Create targets for a list of domains + * Create targets for a list of domains. * * @param srvName The SRV name. * @param domains A list of domains. diff --git a/helios-tools/src/test/java/com/spotify/helios/cli/CliParserTest.java b/helios-tools/src/test/java/com/spotify/helios/cli/CliParserTest.java index ea19c1e1e..5a3c48fda 100644 --- a/helios-tools/src/test/java/com/spotify/helios/cli/CliParserTest.java +++ b/helios-tools/src/test/java/com/spotify/helios/cli/CliParserTest.java @@ -22,7 +22,6 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import com.google.common.base.Charsets; @@ -35,10 +34,8 @@ import java.nio.ByteBuffer; import java.util.Collections; import java.util.List; -import net.sourceforge.argparse4j.inf.ArgumentParserException; import org.junit.Rule; import org.junit.Test; -import org.junit.rules.ExpectedException; import org.junit.rules.TemporaryFolder; public class CliParserTest { diff --git a/pom.xml b/pom.xml index 600f95e55..cd1aafff6 100644 --- a/pom.xml +++ b/pom.xml @@ -14,7 +14,7 @@ com.spotify foss-root - 5 + 9 @@ -786,7 +786,7 @@ org.apache.maven.plugins maven-source-plugin - 2.4 + 3.0.1 attach-sources @@ -799,7 +799,7 @@ org.apache.maven.plugins maven-javadoc-plugin - 2.10.3 + 3.0.1 attach-javadocs