This repository has been archived by the owner on Mar 27, 2021. It is now read-only.
In affected IT.java's, replace inheritance flags with polymorphism #687
Labels
codebase quality
high level issues pertaining to improvements / problems with the codebase's quality
component:all
an issue that pertains to the whole codebase
or in more mechanical terms:
replace:
flags in IT.java base classes like
protected boolean subclassHasFeatureX = true;
+
tests for that flag in the base class e.g.
assumeTrue("Test huge row key write", hugeRowKey)
+
setting of said flag in concrete subclasses e.g.
this.subclassHasFeatureX = false;
with:
FeatureTestImpl
to be a no-op:et voila
no more flags or run time exceptions if the developer forgets that the subclass doesn't support feature X.
See the original comment here.
The text was updated successfully, but these errors were encountered: