Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

SocialAuthenticationFilter filter does not validate state #245

Open
dlvenable opened this issue Dec 15, 2017 · 1 comment
Open

SocialAuthenticationFilter filter does not validate state #245

dlvenable opened this issue Dec 15, 2017 · 1 comment

Comments

@dlvenable
Copy link

The Spring Social demos indicate that using SocialAuthenticationFilter is the preferred way to integrate with Spring Security. Indeed I find it integrates better with Spring Security than using ProviderSignInController. However, the code in SocialAuthenticationFilter doesn't validate the state parameter from Social providers. Thus using it for sign-in appears to open up a security hole.

I'm using Spring Security 1.1.4 and have been able to perform authentication into a simple system with a state which the server requesting Social sign-in never created.

@dlvenable
Copy link
Author

I'd like to follow up on this issue. The OAuth2 spec recommends validating the state parameter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant