Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Gateway SSL Configurer Bundle Bug #3682

Open
pinxiong opened this issue Jan 26, 2025 · 0 comments
Open

Spring Cloud Gateway SSL Configurer Bundle Bug #3682

pinxiong opened this issue Jan 26, 2025 · 0 comments

Comments

@pinxiong
Copy link

pinxiong commented Jan 26, 2025

Describe the bug

When I upgrate spring-cloud-gateway to version 4.2.0, I found that SslBundles does work at all. After deeply diving into the source code, I found that the conditions might have some problems as below:

protected SslBundle getBundle() {
    // this conditional expression is always true
    if (ssl.getSslBundle() == null || ssl.getSslBundle().length() > 0) {
        return null;
    }
    if (bundles.getBundleNames().contains(ssl.getSslBundle())) {
	return bundles.getBundle(ssl.getSslBundle());
    }
    return null;
}

The problem is that the conditional expression is always true below.

if (ssl.getSslBundle() == null || ssl.getSslBundle().length() > 0) {
    return null;
}

Sample

  • Version: 4.2.0
  • Method: AbstractSslConfigurer#getBundle()

Question

I notified that this bug has been reported before, this bug might be fixed in version 4.2.1 .

I was wondering when we can expect an available version to be released?

References

@pinxiong pinxiong changed the title Spring Cloud Gateway SSL Config Bug Spring Cloud Gateway SSL Configurer Bundle Bug Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant