org.springframework.integration.store.SimpleMessageStore.getMessageGroup(Object) not calling this.groupIdToMessageGroup.put(groupId, group);

[brianblank]

In what version(s) of Spring Integration are you seeing this issue?

I can verify that the defect is in latest version, but also I see it in older versions.

Describe the bug

If the groupId is new, group becomes null triggering a call to getMessageGrouFactory().create. The generated group on line 224 is immediately returned. However, if this.copyOnGet==false, it should save a copy of the newly created group by calling "this.groupIdToMessageGroup.put(groupId, group);" like on line 275.

A clear and concise description of what the bug is.

To Reproduce

If you call getMessageGroup(), followed by addMessagesToGroup(), a new group is currently getting created for the same groupId.

Expected behavior

The same group should be used in both calls when the copyOnGet==false.

Sample

A link to a GitHub repository with a minimal, reproducible sample.

https://github.com/spring-projects/spring-integration/blob/main/spring-integration-core/src/main/java/org/springframework/integration/store/SimpleMessageStore.java
lines 223-225 has the bug.
lines 274-275 shows expected behaviour.

Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.

[artembilan]

Thank you for the report!

Looks like you are fully on board with the problem.
I would appreciate if you can contribute the fix with respective unit test to verify: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc