-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect KafkaOperations
instead of KafkaTemplate
for AbstractKafkaListenerContainerFactory#setReplyTemplate
#3524
Comments
@neshkeev I think this is a reasonable request (as far as I can see). Would you be open to sending a PR for this? Then, we can review it and make sure that there are no side effects. |
…r ReplyTemplate Fixes: spring-projects#3524 spring-projects#3524 Replacing `KafkaTemplate` with `KafkaOperations` for Container Factories opens more opportunities for developers to configure replying kafka templates since extending `KafkaTemplate` might not always be possible. Signed-off-by: Nikita Eshkeev <[email protected]>
@sobychacko , please approve my PR so it can trigger a build |
As a project stewarded by US company, we are unable to accept contributions from Russian sources due to US law at this time. |
@artembilan , I understand, no hard feelings. Please consider implementing this idea yourself |
Expected Behavior
It should be possible to pass an implementation of
KafkaOperations
instead ofKafkaTemplate
intoKafkaListenerContainerFactory
since extendingKafkaTemplate
might not always be possible (no default constructor).Current Behavior
Here is a custom implementation of
KafkaOperations
:Unfortunately, I cannot pass an instance of
MyCustomKafkaOperationsImpl
insideKafkaListenerContainerFactory
:Context
Direct extension of
KafkaTemplate
might be impossible since its constructors requires at least aProducerFactory
object.I briefly scanned over the code base, I didn't find any places which require
KafkaTemplate
specific methods, allsend
operations come fromKafkaOperations
The text was updated successfully, but these errors were encountered: