Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum values to springwolf ui #1190

Open
maxdobler opened this issue Feb 21, 2025 · 2 comments
Open

Add enum values to springwolf ui #1190

maxdobler opened this issue Feb 21, 2025 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@maxdobler
Copy link

When reading the documentation on the springwolf-ui it would be nice to see the possible enum values in the schema. I'm used to see this in the swagger-ui and I think it would be a nice addition to springwolfs ui.

Values are already written in the AsyncApi:

"properties": {
          "audioRouting": {
            "type": "string",
            "enum": [
              "DRIVER",
              "PASSENGER",
              "LISTEN_IN",
              "PASSENGER_AND_EXTERNAL"
            ]
          },
...

Actual springwolf-ui:

Image

Inspiration from swagger-ui:

Image

@maxdobler maxdobler added the enhancement New feature or request label Feb 21, 2025
Copy link

Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord.

@timonback
Copy link
Member

timonback commented Feb 21, 2025

Hi @maxdobler
That would be a nice addition.

Current ui includes support for enums, while presentation can always be improved.
Possible starting point: https://github.com/springwolf/springwolf-core/blob/master/springwolf-ui/src/app/components/schema/schema.component.html#L89

Feel free to contribute and open a PR - or anyone else who wants to work on it.

@timonback timonback added the good first issue Good for newcomers label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants