Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Google Gemini API as a Provider #67

Open
shanehuntley opened this issue Sep 29, 2024 · 5 comments · Fixed by #68
Open

Support Google Gemini API as a Provider #67

shanehuntley opened this issue Sep 29, 2024 · 5 comments · Fixed by #68

Comments

@shanehuntley
Copy link
Contributor

Support Google Gemini as a provider via Gemini API
https://ai.google.dev/gemini-api
shanehuntley added a commit to shanehuntley/exchange that referenced this issue Sep 29, 2024
@shanehuntley
feat: Add provide experimental support for Google Gemini square#67
6314a3d
@shanehuntley shanehuntley mentioned this issue Sep 29, 2024
Merged
shanehuntley added a commit to shanehuntley/exchange that referenced this issue Sep 30, 2024
@shanehuntley
feat: Add provide experimental support for Google Gemini square#67
55ab355
adhintz pushed a commit that referenced this issue Oct 1, 2024
@shanehuntley
feat: Add provide experimental support for Google Gemini #67 (#68)
24a9e8b
@adhintz adhintz reopened this Oct 1, 2024
@adhintz
Copy link
Member

adhintz commented Oct 1, 2024

Remaining tasks from the PR review:

  • change to vcr tests
  • try vision model
  • add to pyproject.toml

@codefromthecrypt
Copy link
Contributor

suggest to rename the provider to gemini before releasing, as there's also vertex and may be more in the future.. wdyt? https://www.reddit.com/r/googlecloud/comments/1dr7at1/vertex_ai_api_vs_gemini_api/

also, vision model needs code changes to work, as the images need to be encoded. so, the vision integration test doesn't currently pass

@codefromthecrypt codefromthecrypt mentioned this issue Oct 2, 2024
Closed
@codefromthecrypt
Copy link
Contributor

here are the VCR tests #71

lifeizhou-ap added a commit that referenced this issue Oct 2, 2024
@lifeizhou-ap
Merge branch 'main' into lifei/error-without-env-vars
310abb1 
* main:
  feat: Add provide experimental support for Google Gemini #67 (#68)
@adhintz
Copy link
Member

adhintz commented Oct 2, 2024

suggest to rename the provider to gemini before releasing, as there's also vertex and may be more in the future.. wdyt?

Based on this document it looks like there's Google provider and a Vertex provider. Either one can provide the Gemini model.

@codefromthecrypt
Copy link
Contributor

I guess I mean to say we can make more clear which REST Api we are using. If it is implied, no worries

codefromthecrypt added a commit to codefromthecrypt/goose that referenced this issue Oct 4, 2024
@codefromthecrypt
test: convert Google Gemini tests to VCR
197f0dd 
part of square/exchange#67
closes square/exchange#71

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt mentioned this issue Oct 4, 2024
Merged
codefromthecrypt pushed a commit to codefromthecrypt/exchange that referenced this issue Oct 13, 2024
@jithu123
docs: fixing exchange url to public version (square#67)
71863a1 
Co-authored-by: Jithendranath Joijoide <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add provide experimental support for Google Gemini #67 shanehuntley/exchange
3 participants
@codefromthecrypt @adhintz @shanehuntley