Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to log errors with logger #50

Open
se7entyse7en opened this issue Oct 14, 2019 · 2 comments
Open

Decide whether to log errors with logger #50

se7entyse7en opened this issue Oct 14, 2019 · 2 comments
Labels
enhancement New feature or request needs discussion/agreement This issue needs some discussion or agreement

Comments

@se7entyse7en
Copy link
Contributor

Context: here.

@smacker
Copy link
Contributor

smacker commented Oct 17, 2019

I don't see it as an important issue, I propose to move it to the bottom of the backlog and come back later if we see more inconsistency. Or just close it.
The original comment was more about the reasoning behind the code, not a change request.

@se7entyse7en
Copy link
Contributor Author

The original comment was more about the reasoning behind the code, not a change request

yup, but I think that it makes sense to actually always use logger also for errors that makes the cli exit. For example in case that we redirect the logs to a file. But for sure this is not urgent, I'll just move this at the bottom.

@se7entyse7en se7entyse7en added needs discussion/agreement This issue needs some discussion or agreement enhancement New feature or request labels Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion/agreement This issue needs some discussion or agreement
Projects
None yet
Development

No branches or pull requests

2 participants