Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping the cell crashes the server with uncaught error #323

Open
BeRecursive22 opened this issue Sep 24, 2024 · 2 comments
Open

Stopping the cell crashes the server with uncaught error #323

BeRecursive22 opened this issue Sep 24, 2024 · 2 comments

Comments

@BeRecursive22
Copy link
Contributor

Steps to reproduce:

  • Write/generate Typescript code and run it
  • Stop the cell from running
  • result is server crash
screen-capture.17.webm

Result:

image
@BeRecursive22
Copy link
Contributor Author

@benjreinhart @nichochar just adding try...catch will do the trick I believe. Let me know if you want me to open a PR for this?
const killed = processes.kill(session.id, cell.id);

@Lokendra-sinh
Copy link

hey @nichochar , did you get a chance to reproduce this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants