Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision attacks on packet commitment #13

Open
srdtrk opened this issue Jul 31, 2024 · 0 comments
Open

Collision attacks on packet commitment #13

srdtrk opened this issue Jul 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@srdtrk
Copy link
Owner

srdtrk commented Jul 31, 2024

Right now, the destPort and destChannel are included back to back as utf-8 string bytes in the packet commitment (before sha256 hashing). This means that "transfer", "channel-0" is the same as "trans", "ferchannel-0". This needs to be fixed on ibc-go as well.
@srdtrk srdtrk added the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srdtrk