Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intro to iOS] Assignment 1 - Review my app #1

Open
srochiramani opened this issue May 11, 2015 · 1 comment
Open

[Intro to iOS] Assignment 1 - Review my app #1

srochiramani opened this issue May 11, 2015 · 1 comment

Comments

@srochiramani
Copy link
Owner

/cc @codepath

@codepathreview
Copy link

👍 Nice work! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

  • As a reminder, there are two great style guides in the
    Swift community like Ray Wenderlich's Swift Style Guide and Github's Swift Style Guide
  • You can remove generated Xcode functions, if not used (e.g.
    override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
    }
    )
  • You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.
  • In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.
  • Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
  • Nice work loading the images asynchronously.
  • Nice work setting up the proper modes for the images so that they are not stretched.
  • Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

Feel free to reach out, if you have any questions! I'd be glad to help! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants