Skip to content
This repository has been archived by the owner on Aug 3, 2019. It is now read-only.

setDefaultAudience does not work without facebook app #51

Open
ronlut opened this issue Dec 3, 2013 · 3 comments
Open

setDefaultAudience does not work without facebook app #51

ronlut opened this issue Dec 3, 2013 · 3 comments

Comments

@ronlut
Copy link
Contributor

ronlut commented Dec 3, 2013

Hi.
It's a bug I discovered when I developed the video uploading feature.
When using the library without facebook app installed (my case), SimpleFacebookConfiguration.Builder().setDefaultAudience(audience) doesn't work and it always uses FRIENDS as the default setting.
This is because the [facebook documentation](https://developers.facebook.com/docs/reference/android/current/Session.OpenRequest/#setDefaultAudience(SessionDefaultAudience) declares:

Sets the defaultAudience for the OpenRequest.
This is only used during Native login using a sufficiently recent facebook app.

I'm opening it here as an issue so I won't forget it.
I (and anyone else is welcome) will fix it as soon as I'll have time.

@sromku
Copy link
Owner

sromku commented Dec 3, 2013

Thanks man.
It is interesting. It looks like there is no possible solution for this once native app isn't installed.
If so, maybe the solution, will be just mention it in javadoc of video uploading action.

@ronlut
Copy link
Contributor Author

ronlut commented Dec 3, 2013

I think you got me wrong.
It has nothing to do with video uploading, it's in SimpleFacebookConfiguration class. It sets the default audience settings for the publish permissions dialog.
And it seems there is a solution. It's just calling a different method in the Facebook sdk. I'll add a more detailed explanation as soon as I'll fix it (AND won't be typing from my phone).

@sromku
Copy link
Owner

sromku commented Dec 3, 2013

Ohh, you are right I somehow thought about privacy settings,maybe it's because of a late hours :(

To the real problem, cool that you found such issue.
I will also look into the possible solution and how to handle such case.

Thanks!

@sromku sromku added facebook bug and removed bug labels Mar 10, 2014
@sromku sromku added the to doc label Oct 13, 2014
@sromku sromku added this to the Version 2.2 milestone Oct 13, 2014
@sromku sromku self-assigned this Oct 13, 2014
@sromku sromku removed this from the Version 2.2 milestone Oct 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants