Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note elements in descendant msItems are displaying in the top-level msItem #343

Closed
wlpotter opened this issue Jun 7, 2024 · 2 comments
Closed
Assignees
Labels
Bill2VU bug Something isn't working

Comments

@wlpotter
Copy link
Contributor

wlpotter commented Jun 7, 2024

@wsalesky I wonder if this is related to a change for #341 (nevermind), but appears that all the descendant tei:note elements are displaying at the top-level msItem.

Example record: https://bl.syriac.uk/ms/763

The top-level item (msContents/msItem[1]) only has the first two notes; the rest seem to be coming from msContents/msItem//msItem/note. As far as I can tell the XML data is correct -- though let me know if there is a mistake that I'm not seeing

@wlpotter wlpotter added bug Something isn't working Bill2VU labels Jun 7, 2024
@wsalesky
Copy link
Collaborator

wsalesky commented Jun 7, 2024

@wlpotter opps, yes that is my fault, I will need to find a better way to get the correct notes to display.

wsalesky added a commit that referenced this issue Jun 20, 2024
wsalesky added a commit that referenced this issue Jun 20, 2024
wsalesky added a commit that referenced this issue Jun 20, 2024
@wsalesky
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bill2VU bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants