Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML is not consistent in adding the comma to the 5 digit shelmark #389

Open
davidamichelson opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
Bill2VU bug Something isn't working

Comments

@davidamichelson
Copy link
Contributor

In the main header we don't have it, but in manuscripts with MS Parts we do. See picture showing both 17266 and 17,266
Shelfmarks

I think we decided to consider the non-comma version as the canonical one? Right? This would mean changing MS part display in two places, the table of contents for the page and the header for the msPart.

Thoughts?

@wlpotter
Copy link
Contributor

wlpotter commented Jul 11, 2024

The MS Parts are coming from the BL-Shelfmark (//msPart/msIdentifier/altIdentifier/idno); the version without the comma is from //titleStmt/title[@level="a"].

I believe the version with comma is how Wright has it; without commas was based, I think, on how the BL listed their shelf marks

fwiw it might be easier to target the titles and add a comma using regex than it would to remove the comma from the shelf mark idnos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bill2VU bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants