Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how we handle events of @type Veneration #1195

Open
davidamichelson opened this issue Jul 23, 2024 · 7 comments
Open

Update how we handle events of @type Veneration #1195

davidamichelson opened this issue Jul 23, 2024 · 7 comments
Assignees

Comments

@davidamichelson
Copy link
Contributor

Need to work out TEI for this.

Originally posted by @davidamichelson in #1192 (comment)

@davidamichelson
Copy link
Contributor Author

Break multiple dates out into separate event elements
Add prose dates the desc element a @when attribute on event when on the Gregorian calendar.
For other calendars, use @when-custom and @datingMethod

@dlschwartz
Copy link
Contributor

dlschwartz commented Oct 16, 2024

A few complications here.

  • Ten records have dates with the format ##/##/####. It is pretty clear that the text nodes in all of these tei:desc elements were auto-generated using a script. I'm assuming the text came from a spreadsheet cell. It looks to me like these dates were mistakenly auto-formatted by Google sheets. In each case the year is 2014 where most of our veneration events contain day and month dates. For an example, see 1095. The question is, what date was supposed to be in the original spreadsheet cell? Is it safe to assume that the day and month are correct and we can just lop off the year?
    • Yes these 2014 years were auto filled, please delete the years. I checked the originals.
  • We have commemorations on the liturgical calendar that cannot easily be rendered with a W3C date. See, for example, person/306: "sixth friday of epiphany". This is really difficult to render as a triple.
    • In such cases could we simply leave the date in the desc as a prose string without supplying date attributes (converted or otherwise)?
  • I've never been good with numbers/dates in Latin, does "feria VI, secundae hebdomadis aestivae" in 1358 mean "the sixth day of the second week of summer"?
    • We should just translate this to English, I think your translation is right but let's ask @jsaintlauren
  • Some dates just aren't clear
    • person/1497: "Iun. 9, (6, 5)". Does that mean June 9th or 6th or 5th?
    • person/2823: Does "West Syrians: March 1, 11, 13 and 14 of May, August 1" mean 1 March, 11 May, 13 May, 14 May, and 1 August?
    • person/1113; it is unclear which dates go with which communities.
      -We need to clear these up by hand.

@dlschwartz
Copy link
Contributor

dlschwartz commented Oct 16, 2024

Some questions regarding the religious confessions used in these events:

  • If no community is listed, can one be assumed? For example, does BHO have a default community in mind, or is that not how our sources for commemoration work?
  • Hard to say, it might mean an early saint with a common data across traditions. Probably need to check these individually
  • "West Syrians" = "Syr. iacob."? yes
  • "Syr." = East and West Syriac? don't know
  • "in Rabban Saliba" = West Syriac? yes

@dlschwartz
Copy link
Contributor

dlschwartz commented Oct 17, 2024

And another question regarding sourcing. A number of entries include a "(BHO)" at the end. They do not, however, contain a @source attribute pointing to BHO. Is this a sourcing error? Does the source cited and BHO contain this information? Can we delete "(BHO)" or should we add it to the @source attribute?

Can you send an example record? It might mean the BHO data was the same as FIey, in which case we could just cite Fiey

Here is an example: https://github.com/srophe/syriaca-data/blob/development/data/persons/tei/93.xml#L307

@dlschwartz
Copy link
Contributor

@wlpotter The above commit has my updates. It would be great if the spreadsheet could solicit the following from Nunzia

  • religious communities where lacking if possible
  • combinations of communities and dates if possible
  • clarification regarding what is meant by "Syr."
  • bibl information that would allow us to remove "(BHO)" in favor of a @source attribute

If you could also let her know that there is a preference for cleaning existing data rather than adding. It would be great if she wanted to add data but that is not a short-term priority.

Thanks Will!

@wlpotter
Copy link
Contributor

wlpotter commented Oct 22, 2024

@dlschwartz this sheet has info from the current data. Feel free to add columns to it for the info you want Nunzia to supply.

Having dates as something she'll comment on makes me wonder if I should pull out info from the date attributes?

I would imagine the following columns might be useful:

  • religious communities (when not tagged) -- might be somewhat difficult to reincorporate this as a tagged string with the rs element but should be possible
  • notes column -- might be the best way to note the combo of dates and communities to start with; and to clarify "Syr."
  • BHO entry number source. We can use this column on re-ingest to either add to the source attribute (if we already cite BHO in the record) or to create a bibl for BHO
    • Might want additional bibl columns for other sources Nunzia might check?

@dlschwartz
Copy link
Contributor

I think this looks great. Thanks Will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants