Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential message loss due to queue filtering #1680

Open
moshe-blox opened this issue Sep 1, 2024 · 1 comment
Open

potential message loss due to queue filtering #1680

moshe-blox opened this issue Sep 1, 2024 · 1 comment
Labels
alan bug Something isn't working
Milestone

Comments

@moshe-blox
Copy link
Contributor

moshe-blox commented Sep 1, 2024

Since we've changed the filtering mechanism recently, and maybe even prior to that, there's the theoretical issue of a consumer refusing to pop certain messages because the Runner never gets to a certain state where it wants these messages, and therefore the queue grows bigger and bigger until it starts dropping messages, potentially even ExecuteDuty messages.

We should examine if our codebase has this issue in practice, and if so maybe we should consider clearing messages that are no longer relevant once the queue hits capacity.

Additionally, we should add unit tests for the various real-world scenarios that occur with message filtering. These tests should be in committee_queue_test.go and invoke the exact same filtering logic as Committee does.

@moshe-blox moshe-blox added bug Something isn't working alan labels Sep 1, 2024
@moshe-blox moshe-blox added this to the Alan milestone Sep 1, 2024
@y0sher
Copy link
Contributor

y0sher commented Sep 2, 2024

I think thorough testing to the queue prioritization flow will help us be relaxed about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alan bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants