Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

differ produces incorrect diffs #1681

Open
moshe-blox opened this issue Sep 1, 2024 · 0 comments · Fixed by #1719
Open

differ produces incorrect diffs #1681

moshe-blox opened this issue Sep 1, 2024 · 0 comments · Fixed by #1719
Labels
bug Something isn't working

Comments

@moshe-blox
Copy link
Contributor

I've noticed that on main branch the method ProposerRunner.ProcessPreConsensus is somehow cut and shuffled in the middle.

We should add yet another unit test to reproduce it in differ and fix that problem.
@moshe-blox moshe-blox added the bug Something isn't working label Sep 1, 2024
@moshe-blox moshe-blox mentioned this issue Sep 1, 2024
Open
@moshe-blox moshe-blox linked a pull request Sep 10, 2024 that will close this issue
fix: (differ) incorrect diffs #1719
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: (differ) incorrect diffs ssvlabs/ssv
1 participant
@moshe-blox