You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use case: If you try to create a connection to a DCOM server (OPCDA Server in my example), but misspelled the IP address. Currently the socket setup just runs forever, but your library already has a timeout setting and the ComTransport also has an event listener to the 'error' event, but you have to do something there that actually signals the failed connection attempt to the client application.
I've filed a proposed solution in #5 which reliably returns an error if the initial connection attempt fails due to e.g. a non-existing IP address.
The text was updated successfully, but these errors were encountered:
Hi there. I'll be taking over the work on these nodes. I'm not as familiar with this code base as in other repos here, but from the changes proposed in the PR, i'd say they do make sense. We cannot just rely on OS events to assume the connection is broken.
What has caught my attention although is the handling of the timer created. Usually we need to clear the timer not only when the connection is successful (as it seems to be done there), but also when the object/instance is being destroyed/disconnected. I've seen some nasty bugs caused on race conditions like that. I'll need to find some time here to analyze the code path and setup an environment for some testing. I know this is months old already, but I'll need a bit more time to get this properly tested and fixed, sorry for that!
Use case: If you try to create a connection to a DCOM server (OPCDA Server in my example), but misspelled the IP address. Currently the socket setup just runs forever, but your library already has a timeout setting and the ComTransport also has an event listener to the 'error' event, but you have to do something there that actually signals the failed connection attempt to the client application.
I've filed a proposed solution in #5 which reliably returns an error if the initial connection attempt fails due to e.g. a non-existing IP address.
The text was updated successfully, but these errors were encountered: