Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signer] Miner activity should only count specific bad block proposals #5749

Open
jferrant opened this issue Jan 27, 2025 · 0 comments
Open
Assignees
Labels
Milestone

Comments

@jferrant
Copy link
Collaborator

jferrant commented Jan 27, 2025

Currently signers will count any block proposal that passes initial checks towards miner activity. However, a signer should be smarter about what counts as activity as a miner could simply having an outdated view or it could actually be a bad tenure where that miner will either not catch up/is misconfigured/is malicious.

Add a database table that tracks consensus hash to a last active timestamp. This last active timestamp should be used in the is_timed_out fn check in chainstate.rs. If a tenure has not had a single approved block, check this last active timestamp against the block_proposal_timeout.

This timestamp should get updated if a block proposal tries to reorg the last block of the prior tenure but only within a certain number of seconds of the tenure start and only block proposals at the tenure change boundary really matter. I.e. these block proposals will also have to pass tenure change transaction validity checks. It may need to accomodate locally vs globally accepetd block reorg attempts as well.

@jferrant jferrant self-assigned this Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 27, 2025
@jferrant jferrant added this to the 3.1.0.0.5 milestone Jan 27, 2025
@jferrant jferrant changed the title [Signer] Miner activity should be only count specific bad block proposals [Signer] Miner activity should only count specific bad block proposals Jan 27, 2025
@jferrant jferrant moved this from Status: 🆕 New to Status: In Review in Stacks Core Eng Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: In Review
Development

No branches or pull requests

1 participant