Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better miner won_sortition? detection on restart #5750

Closed
kantai opened this issue Jan 27, 2025 · 1 comment
Closed

Better miner won_sortition? detection on restart #5750

kantai opened this issue Jan 27, 2025 · 1 comment

Comments

@kantai
Copy link
Member

kantai commented Jan 27, 2025

Currently, the stacks-node miner uses their last submitted block commits to determine if they won a sortition. This state is stored only in memory, so on restart, the miner may be unaware of the fact that they won the current tenure. This will lead to an empty tenure.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 27, 2025
kantai added a commit that referenced this issue Jan 27, 2025
@kantai
fix: #5750 better win detection on restart
64ef3d3
kantai added a commit that referenced this issue Jan 27, 2025
@kantai
fix: #5750 better win detection on restart
e6b8ca9
@kantai kantai mentioned this issue Jan 27, 2025
Merged
@kantai
Copy link
Member Author

kantai commented Feb 4, 2025

Fixed in #5752

@kantai kantai closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kantai