Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: nakamoto_integrations::flash_blocks_on_epoch_3 #5765

Open
jbencin opened this issue Jan 29, 2025 · 1 comment
Open

Flaky test: nakamoto_integrations::flash_blocks_on_epoch_3 #5765

jbencin opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels

Comments

@jbencin
Copy link
Contributor

jbencin commented Jan 29, 2025

This test is flaky and sometimes fails

Example in CI: https://github.com/stacks-network/stacks-core/actions/runs/12960831292/job/36155549996?pr=5746#step:6:2253

The error:

thread 'tests::nakamoto_integrations::flash_blocks_on_epoch_3' panicked at testnet/stacks-node/src/tests/nakamoto_integrations.rs:1837:5:
assertion `left == right` failed: Burn chain tip should have advanced by 4 blocks
  left: 231
 right: 233

It looks like we need to give it some time to process the new burn blocks, but if I add a sleep() I get other failures later

Do we actually need this test? It looks like it's testing Epoch 2 -> 3 transition, which has already happened and doesn't need further testing

@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 29, 2025
@jbencin jbencin self-assigned this Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 29, 2025
@jbencin jbencin added flaky and removed lint Related to linting/clippy/cargo warns labels Jan 29, 2025
@obycode
Copy link
Contributor

obycode commented Jan 29, 2025

Yeah, that feels like it could be ignored now if it's troublesome, similar to what we did with the test for disabling microblocks at 2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants