Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy strips secret from webhook #94

Open
nnachefski opened this issue Dec 9, 2020 · 0 comments · May be fixed by #105
Open

Proxy strips secret from webhook #94

nnachefski opened this issue Dec 9, 2020 · 0 comments · May be fixed by #105

Comments

@nnachefski
Copy link

nnachefski commented Dec 9, 2020 •
edited
Loading

I noticed that my secret is no longer valid after the webhook traverses the proxy. Would it be possible to preserve the secret so i can also validate with my listener running on internal kube ?
gnieto added a commit to gnieto/GitWebhookProxy that referenced this issue Apr 8, 2022
@gnieto
Forward all known github headers
041353e 
Previous implementation was preventing to proxy signature headers,
unless some secret was set up.

By forwarding all the known GitHub headers, upstream service can do this
checks. Note that this do not break the signature validation on this
proxy.

I've also added the sha256 signature header to the list of known GitHub
headers.

Fixes: stakater#94
@gnieto gnieto linked a pull request Apr 8, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward all known GitHub headers gnieto/GitWebhookProxy
1 participant
@nnachefski