From 224cf3d38989d0d5bada41dece2dd1ccae094e69 Mon Sep 17 00:00:00 2001 From: arielly-parussulo <97965681+arielly-parussulo@users.noreply.github.com> Date: Tue, 31 Dec 2024 10:19:02 +0100 Subject: [PATCH] fix: Remove default values for rollingUpdate (#360) Co-authored-by: Zadkiel AHARONIAN #minor --- README.md | 2 -- application/values.yaml | 10 +++------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index e1b70455..0b468b77 100644 --- a/README.md +++ b/README.md @@ -63,8 +63,6 @@ helm delete --namespace test my-application | deployment.annotations | object | `nil` | Annotations for Deployment. | | deployment.additionalPodAnnotations | object | `nil` | Additional pod annotations. | | deployment.strategy.type | string | `"RollingUpdate"` | Type of deployment strategy. | -| deployment.strategy.rollingUpdate.maxUnavailable | string | `"25%"` | Max unavailable pods during update. | -| deployment.strategy.rollingUpdate.maxSurge | string | `"25%"` | Max surge pods during update. | | deployment.reloadOnChange | bool | `true` | Reload deployment if attached Secret/ConfigMap changes. | | deployment.nodeSelector | object | `nil` | Select the node where the pods should be scheduled. | | deployment.hostAliases | list | `nil` | Add host aliases to the pods. | diff --git a/application/values.yaml b/application/values.yaml index 5298dd36..cbdb247c 100644 --- a/application/values.yaml +++ b/application/values.yaml @@ -102,13 +102,9 @@ deployment: # -- (string) Type of deployment strategy. # @section -- Deployment Parameters type: RollingUpdate - rollingUpdate: - # -- (string) Max unavailable pods during update. - # @section -- Deployment Parameters - maxUnavailable: 25% - # -- (string) Max surge pods during update. - # @section -- Deployment Parameters - maxSurge: 25% + # rollingUpdate: + # maxUnavailable: 25% + # maxSurge: 25% # -- (bool) Reload deployment if attached Secret/ConfigMap changes. # @section -- Deployment Parameters reloadOnChange: true