Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSG_TO_L1.to_address should be an ETH_ADDRESS #224

Open
ArielTM opened this issue Aug 4, 2024 · 0 comments · May be fixed by #225
Open

MSG_TO_L1.to_address should be an ETH_ADDRESS #224

ArielTM opened this issue Aug 4, 2024 · 0 comments · May be fixed by #225

Comments

@ArielTM
Copy link

ArielTM commented Aug 4, 2024

MSG_TO_L1.to_address is defined as FELT

"$ref": "#/components/schemas/FELT"

Which is being checked against the following regex:
"pattern": "^0x(0|[a-fA-F1-9]{1}[a-fA-F0-9]{0,62})$"

But "to_address" is essentially an Eth address which normally contain a leading zeroes when needed.

For example, the receipt of "0x06b7f4ac059de44c9c9d9fc6ddbabe35424e3fe35b97403de41f39a63667ff9b" tx contain a message to an address with a leading zero:
https://starkscan.co/tx/0x06b7f4ac059de44c9c9d9fc6ddbabe35424e3fe35b97403de41f39a63667ff9b#messagelogs

Getting the receipt of this tx might cause an error when validating against the regex as mentioned here:
software-mansion/starknet.py#1423

@ArielTM ArielTM linked a pull request Aug 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant