Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #82

Open
11 tasks
epost opened this issue Oct 14, 2018 · 1 comment
Open
11 tasks

Refactor #82

epost opened this issue Oct 14, 2018 · 1 comment
Assignees
@epost

Comments

@epost
Copy link
Member

epost commented Oct 14, 2018 •
edited
Loading

  • Document; add doc comments, etc.
    • Document Collage
  • lookup2
  • Use Foldable, etc. instead of List
  • eliminate Prelude.-prefixed function applications, e.g. Prelude.map (also consider Set.map)
  • align and indent stuff properly
  • Look at existentials, constraint kinds, ...
  • ADT instead of Stringly typed errors
  • Factor out common code
  • eliminate fromJusts if possible
  • ...
@epost epost self-assigned this Oct 14, 2018
epost added a commit that referenced this issue Oct 18, 2018
@epost
First batch of refactorings. #82
5cebd35
epost added a commit that referenced this issue Oct 18, 2018
@epost
Second batch of refactorings. #82
ce69f7c
epost added a commit that referenced this issue Oct 19, 2018
@epost
Third batch of refactorings. #82
3788609
epost added a commit that referenced this issue Oct 19, 2018
@epost
Fix to thhird batch of refactorings. #82
8bd1e39
epost added a commit that referenced this issue Oct 19, 2018
@epost
Flip subst' params. #82
1ac1993
epost added a commit that referenced this issue Oct 19, 2018
@epost
Fourth batch of refactorings. #82
3953fd5
wisnesky added a commit that referenced this issue Oct 19, 2018
@wisnesky
Merge pull request #89 from statebox/82/refactor
3d3811a 
Refactor. #82 (WIP, don't merge!)
epost added a commit that referenced this issue Oct 20, 2018
@epost
Fifth wee batch of refactorings. #82
27a833b
epost added a commit that referenced this issue Oct 20, 2018
@epost
Fifth wee batch of refactorings. #82
702e6b9
epost added a commit that referenced this issue Oct 20, 2018
@epost
Sixth batch of refactorings + some fixes to broken build. #82
3c4d583
epost added a commit that referenced this issue Oct 20, 2018
@epost
Replace foldl by any. #82
b2e4a1c
epost added a commit that referenced this issue Oct 20, 2018
@epost
Replace any by elem. #82
8c56f52
@wisnesky wisnesky mentioned this issue Oct 20, 2018
Closed
epost added a commit that referenced this issue Oct 21, 2018
@epost
Clean up Program.hs. #82
975544d
epost added a commit that referenced this issue Oct 21, 2018
@epost
Clean up Program.hs. #82
ed8f802
epost added a commit that referenced this issue Oct 21, 2018
@epost
Clean up Program.hs. #82
e46543b
wisnesky added a commit that referenced this issue Oct 21, 2018
@wisnesky
Merge pull request #97 from statebox/83/refactor-3
f0e60b3 
Clean up Program.hs. #82
epost added a commit that referenced this issue Oct 23, 2018
@epost
Formatting, unqualifying fns, etc. #38 #82
d03f184
epost added a commit that referenced this issue Oct 23, 2018
@epost
Indent, unqualify fns, etc. #38 #82
a058652
wisnesky added a commit that referenced this issue Oct 23, 2018
@wisnesky
Merge pull request #104 from statebox/82/refactor-5
15c28df 
Indent, unqualify fns, etc. #38 #82
@wisnesky
Copy link
Contributor

  • use folds instead of recursion
  • the common idiom for (x in X) { updateInPlace(A,x), updateInPlace(B,x),...} gets 'shredded' into a collection of maps over X in Haskell in many places. These places should probably use the state monad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epost epost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epost @wisnesky